From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AF0321E14549 for ; Tue, 15 Aug 2017 03:59:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66012EE598; Tue, 15 Aug 2017 11:01:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 66012EE598 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-68.phx2.redhat.com [10.3.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BBEC5D967; Tue, 15 Aug 2017 11:01:27 +0000 (UTC) To: "Kinney, Michael D" , edk2-devel-01 Cc: Ard Biesheuvel , "Justen, Jordan L" , Leif Lindholm References: <20170811164851.9466-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <20d2afa8-3bd9-8088-7248-53a656555568@redhat.com> Date: Tue, 15 Aug 2017 13:01:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 15 Aug 2017 11:01:28 +0000 (UTC) Subject: Re: [edk2-CCodingStandardsSpecification PATCH 0/2] improvements related to line wrapping X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 10:59:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Mike, On 08/11/17 19:07, Kinney, Michael D wrote: > Laszlo, > > You can also provide links to the GitHub commits with "?w=1" > flag appended. If you select the "Display the rich diff" button > above each changed file, GitHub renders a view with change bars. > > https://github.com/lersek/edk2-CCodingStandardsSpecification/commit/2c5534a24b15616fdaa02478858ed1d8908dc653?w=1 I opened two browser tabs with this link, one without "?w=1" and another with "?w=1", and compared the contents visually (by switching back and forth between the tabs), checking each screen-ful. I'm not seeing any differences. When I click the button that you mention, I do get a rendered diff as well. I wonder if this feature is javascript-only, or if it can be triggered with URL changes. Thanks Laszlo > > https://github.com/lersek/edk2-CCodingStandardsSpecification/commit/e3797dc48316052005cefa26246ab2fd32641881?w=1 > > Best regards, > > Mike > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, August 11, 2017 9:49 AM >> To: edk2-devel-01 >> Cc: Ard Biesheuvel ; Justen, Jordan L >> ; Leif Lindholm >> ; Kinney, Michael D >> >> Subject: [edk2-CCodingStandardsSpecification PATCH 0/2] >> improvements related to line wrapping >> >> We've discussed these ideas repeatedly over time; I'm now >> attempting to >> formalize them. Also test-driving the documentation contribution >> process. >> >> - Repo: https://github.com/lersek/edk2- >> CCodingStandardsSpecification.git >> - Branch: line_wrapping >> - Rendered views of the pages modified: >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- >> coding-standards-sp/content/v/line_wrapping/#edk-ii-c-coding- >> standards-specification >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- >> coding-standards-sp/content/v/line_wrapping/5_source_files/#51- >> general-rules >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- >> coding-standards- >> sp/content/v/line_wrapping/5_source_files/52_spacing.html#52- >> spacing >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> >> Thanks >> Laszlo >> >> Laszlo Ersek (2): >> Source Files / General Rules: limit line lengths to 80 columns >> Source Files / Spacing / Multi-line func. calls: allow >> condensed >> arguments >> >> 5_source_files/52_spacing.md | 29 +++++++++++++++++++- >> 5_source_files/README.md | 17 ++++++++---- >> README.md | 2 ++ >> 3 files changed, 42 insertions(+), 6 deletions(-) >> >> -- >> 2.13.1.3.g8be5a757fa67 >