From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D15FF21DFA7BA for ; Tue, 28 Mar 2017 11:00:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 463A2EC0A0; Tue, 28 Mar 2017 18:00:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 463A2EC0A0 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 463A2EC0A0 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-89.phx2.redhat.com [10.3.116.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id 24D6117ACE; Tue, 28 Mar 2017 18:00:54 +0000 (UTC) To: Ard Biesheuvel References: <20170328161500.2737-1-ard.biesheuvel@linaro.org> <86b65788-5506-3e87-807a-f3c75859cde6@redhat.com> Cc: "edk2-devel@lists.01.org" , Marcin Wojtas , Leif Lindholm From: Laszlo Ersek Message-ID: <20eb1848-2d88-8f4b-5ef9-f239929fc175@redhat.com> Date: Tue, 28 Mar 2017 20:00:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 28 Mar 2017 18:00:56 +0000 (UTC) Subject: Re: [PATCH v2] EmbeddedPkg: add DT platform driver to select between DT and ACPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 18:00:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 03/28/17 19:30, Ard Biesheuvel wrote: > On 28 March 2017 at 18:26, Laszlo Ersek wrote: >>>> +#define DT_ACPI_VARIABLE_NAME L"DtAcpiPref" >> Can you replace this instance of "... DtAcpiPref ..." with "... %a ..." >> and DT_ACPI_VARIABLE_NAME? No need to resubmit. >> > > That should be %s, I suppose? Heh, sure. Forgot the L by the time I got there :)