public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Jeff Brasen <jbrasen@nvidia.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library
Date: Tue, 19 Jul 2022 08:22:03 -0700	[thread overview]
Message-ID: <21049.1658244123447276786@groups.io> (raw)
In-Reply-To: <92bf2e8419e091c86366322ad654e5efc809627e.1657313523.git.jbrasen@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi Jeff,

Thank you for this patch.

I have some minor updates like removing ssdtpcieosctemplate_aml_code[] from SsdtPcieGenerator.h as it has been moved to SsdtPcieSupportLibPrivate.h, and adding SsdtPcieSupportLib to DynamicTables.dsc.inc so that the Package Dsc build succeeds.
Otherwise, these changes look good to me.

I will make the changes locally before pushing.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 519 bytes --]

  reply	other threads:[~2022-07-19 15:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08 20:59 [PATCH v3 0/3] DynamicTablesPkg: Pcie generation updates Jeff Brasen
2022-07-08 20:59 ` [PATCH v3 1/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value Jeff Brasen
2022-07-19 15:15   ` [edk2-devel] " Sami Mujawar
2022-07-08 20:59 ` [PATCH v3 2/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF Jeff Brasen
2022-07-19 15:17   ` [edk2-devel] " Sami Mujawar
2022-07-08 20:59 ` [PATCH v3 3/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library Jeff Brasen
2022-07-19 15:22   ` Sami Mujawar [this message]
2022-07-12  7:46 ` [PATCH v3 0/3] DynamicTablesPkg: Pcie generation updates PierreGondois
2022-07-20  8:03   ` [edk2-devel] " Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21049.1658244123447276786@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox