From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library
To: Jeff Brasen <jbrasen@nvidia.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: Cambridge, England, GB (217.140.106.51)
X-Originating-Platform: Windows Firefox 102
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Tue, 19 Jul 2022 08:22:03 -0700
References: <92bf2e8419e091c86366322ad654e5efc809627e.1657313523.git.jbrasen@nvidia.com>
In-Reply-To: <92bf2e8419e091c86366322ad654e5efc809627e.1657313523.git.jbrasen@nvidia.com>
Message-ID: <21049.1658244123447276786@groups.io>
Content-Type: multipart/alternative; boundary="J1ylgjGLquWifEe4oF7P"

--J1ylgjGLquWifEe4oF7P
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Jeff,

Thank you for this patch.

I have some minor updates like removing ssdtpcieosctemplate_aml_code[] from=
 SsdtPcieGenerator.h as it has been moved to SsdtPcieSupportLibPrivate.h, a=
nd adding SsdtPcieSupportLib to DynamicTables.dsc.inc so that the Package D=
sc build succeeds.
Otherwise, these changes look good to me.

I will make the changes locally before pushing.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

--J1ylgjGLquWifEe4oF7P
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Jeff,<br /><br />Thank you for this patch. <br /><br />I have some minor=
 updates like removing ssdtpcieosctemplate_aml_code[] from SsdtPcieGenerato=
r.h as it has been moved to SsdtPcieSupportLibPrivate.h, and adding SsdtPci=
eSupportLib to DynamicTables.dsc.inc so that the Package Dsc build succeeds=
.<br />Otherwise, these changes look good to me.<br /><br />I will make the=
 changes locally before pushing.<br /><br />Reviewed-by: Sami Mujawar &lt;s=
ami.mujawar@arm.com&gt;<br /><br />Regards,<br /><br />Sami Mujawar

--J1ylgjGLquWifEe4oF7P--