From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by mx.groups.io with SMTP id smtpd.web12.10451.1638959782342327025 for ; Wed, 08 Dec 2021 02:36:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.de header.s=2017 header.b=BaWdZ2cd; spf=pass (domain: posteo.de, ip: 185.67.36.66, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 4275F240101 for ; Wed, 8 Dec 2021 11:36:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1638959773; bh=uKo0okMGBEeTRAeSdXLMVKgHVmlnvvNd8APMnA5jTYc=; h=Date:Subject:To:From:From; b=BaWdZ2cdVxak1x7OdHuvMQza4NaBW+JTXEAjzRYrZi1nJIiCp5W3voaNJ2UQLE+bT 81rKQ+ijz0MgqN4DgaPNUAOqw0xt+/8pk6lmNrP7YP1LpJ+0azDTMVx4mXNKQN/kNu URw4j0Xyvxy0YFStTJ62M5Z8Q77z2Pki795dCWrwygfm62sJegkD6XOg4REGjtCQag ICEfj0Rkkhb6HwvBChvHZREnp5mEfL8geCn+hb+Cmp3BwJAm1mKK/es0ya03qHl36E +3j49WBmg64ZgBm/mDd1TxHud1cg8B3zhJt4BpGkJ+aa3RL9MC66kC75uRRGq7lx4/ d0Oota0Cazwfg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4J8D98027Cz6tmR; Wed, 8 Dec 2021 11:36:11 +0100 (CET) Message-ID: <21068346-05f5-bfd2-a328-25888f3c1835@posteo.de> Date: Wed, 8 Dec 2021 10:36:11 +0000 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros To: mjsbeaton@gmail.com, devel@edk2.groups.io References: <56c7bb53-a6d0-efae-bf1d-20824b6c2fa8@posteo.de> <8622.1638954608442666504@groups.io> From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= In-Reply-To: <8622.1638954608442666504@groups.io> Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hey Mike, Thanks! I agree using "offset" may make it more readable, but I haven't seen it being used much outside of memory terminology (the macro also applies to plain integers). Any feedback from the maintainers for preferences? Thanks! Best regards, Marvin On 08.12.21 10:10, mjsbeaton@gmail.com wrote: > Can I tentatively suggest ALIGN_VALUE_OFFSET as a better name? > (Speaking as a native English speaker, and with a relatively high > level of command including technical language, addend is not at all a > common word!) While I'm here additional ping and +1 for this to be > merged, pls!