From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by mx.groups.io with SMTP id smtpd.web08.30530.1649690664025877801
 for <devel@edk2.groups.io>;
 Mon, 11 Apr 2022 08:24:24 -0700
Authentication-Results: mx.groups.io;
 dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jCrYYmx0;
 spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.100, mailfrom: maciej.rabeda@linux.intel.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649690664; x=1681226664;
  h=message-id:date:mime-version:subject:from:to:cc:
   references:in-reply-to:content-transfer-encoding;
  bh=BY5am6d91Aha5ljH+H/sy3z5mLrppLoakWciv10j7gU=;
  b=jCrYYmx05pY6n/mt9FeC4maMzqfZxjIM+aI94gwlJNpE7qhIUPxw0+Wo
   BcRGbzIhtR3XCXOONUXT6xbO5TBWNVP1lVpBiUQSa8pCU+fBks+btBWAY
   Y59KEMS/t/A2yv2l0kkvr8dVisjp7FdvCdvvs+QLpJ9aW+R1PR1sFJXoV
   uJb2GVATf/NCri4xFrxWk0gc4XSSD1Mhwe1CSP+nj+0GJZ1iAZbC8SXOy
   bWATHvrMTABKjTOO+0s6GH2Y/Khr54aFFTOY4Nj1IN9YmmB3+R1P+IdpO
   iRqYRjKddGc/YTNkhRnWiJnQAM0uF/5e04rOglqG8d+Y+MPBOKmO8AeEl
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="325054773"
X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; 
   d="scan'208";a="325054773"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 08:24:21 -0700
X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; 
   d="scan'208";a="551183360"
Received: from mrabeda-mobl2.ger.corp.intel.com (HELO [10.102.8.146]) ([10.102.8.146])
  by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 08:24:20 -0700
Message-ID: <21208a04-4081-ce33-09a8-b08f73fb55ae@linux.intel.com>
Date: Mon, 11 Apr 2022 17:24:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAwLzVdIEh0dHAgRml4ZXMgKFRha2UgVHdvKQ==?=
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Gerd Hoffmann <kraxel@redhat.com>, gaoliming@byosoft.com.cn,
 jiaxin.wu@intel.com, siyuan.fu@intel.com
References: <20220304130403.47832-1-osteffen@redhat.com>
 <20220322133008.152037-1-osteffen@redhat.com>
 <01f201d83e53$ff55a440$fe00ecc0$@byosoft.com.cn>
 <20220407095750.rqwjlf3cvcj2gy5f@sirius.home.kraxel.org>
 <10f3672d-9e0c-61be-344d-9b8a2675942e@linux.intel.com>
 <CA+bRGFpNYEGDdszG+_fg+5BLqj6ERv7TEOgTo-WHw7MrFbm+WQ@mail.gmail.com>
 <6f5285bf-4c1b-b67e-c7dd-0215e7f43725@linux.intel.com>
In-Reply-To: <6f5285bf-4c1b-b67e-c7dd-0215e7f43725@linux.intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Patchset merged: https://github.com/tianocore/edk2/pull/2756

On 8 kwi 2022 11:07, Rabeda, Maciej wrote:
> Alright.
>
> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>
> Merge soon.
>
> On 7 kwi 2022 14:55, Oliver Steffen wrote:
>> On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej
>> <maciej.rabeda@linux.intel.com> wrote:
>>
>>> 1. In HttpResponseWorker():
>>>
>>>       if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen
>>> ("HTTP/1.0")) == 0) {
>>>         DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0. Setting
>>> Connection close.\n"));
>>>         HttpInstance->ConnectionClose = TRUE;
>>>       }
>>>
>>> I'd change AsciiStrLen ("HTTP/1.0") to sizeof("HTTP/1.0") - 1. No need
>>> to call a AsciiStrLen every time this flow is executed, it is easily a
>>> compile-time thing.
>> Yes, of course.
>>
>>> 2. In HttpResponseWorker(), index -> Index, coding standard.
>> Sorry, I missed that one.
>>
>>> I can merge this patch with changes above one I get an ACK from you.
>> Sounds good to me. Thank you!
>>
>> -- Oliver
>>
>>
>>
>> 
>>
>>