From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D9FCF21A143EF for ; Fri, 6 Jul 2018 07:01:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D1E187A6E; Fri, 6 Jul 2018 14:01:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-154.rdu2.redhat.com [10.10.120.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA117215688A; Fri, 6 Jul 2018 14:01:04 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Lendacky Thomas , Ard Biesheuvel , Anthony Perard , Julien Grall , Justen Jordan L References: <1530817945-8030-1-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <2125f952-69e6-6093-3761-fb5d6e5547ea@redhat.com> Date: Fri, 6 Jul 2018 16:01:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1530817945-8030-1-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 06 Jul 2018 14:01:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 06 Jul 2018 14:01:06 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v3 0/3] OvmfPkg: mark flash memory range as MMIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 14:01:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/05/18 21:12, Brijesh Singh wrote: > The Qemu flash range is marked as 'system ram' in EFI runtime memmap > but it is actually an IO address. The patch series updates the > EFI runtime memmap to add this range as Memory Mapped IO address. > > Changes since v2: > - added cover letter and extend CC list to add all OvmfPkg > maintainers/reviewers. > > Changes since v1: > - split the OvmfPkg single patch into three patches based on Laszlo's feedback. > a) mark memory as MMIO for non SEV case > b) do not adding EFI runtime mapping for SMM build > c) clear C-bit when SEV is active for non SMM builds only > > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Cc: Justen Jordan L > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > > Complete tree is available: > url: https://github.com/codomania/edk2.git > branch: qemu-flash-mmio > > Brijesh Singh (3): > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as > MMIO > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Do not expose MMIO in SMM > build > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Restore C-bit when SEV is > active > > .../FvbServicesRuntimeDxe.inf | 1 + > .../FwBlockService.c | 38 +----------- > .../FwBlockService.h | 7 +++ > .../FwBlockServiceDxe.c | 68 ++++++++++++++++++++++ > .../FwBlockServiceSmm.c | 13 +++++ > 5 files changed, 90 insertions(+), 37 deletions(-) > Regression tested -- only without SEV -- on top of commit 9090c8b53301, using the configs below. The "rdmsr" and "efibootmgr" checks are explained at . * i440fx, X64, without SMM: (01) Fedora 28 guest, efibootmgr + rdmsr checks after boot and S3: PASS (02) RHEL 6 guest, efibootmgr check after boot: PASS (03) RHEL 7 guest, efibootmgr check after boot and S3: PASS (04) Windows 7 guest, boot and S3: PASS * q35, IA32, with SMM: (05) Fedora 26 guest, efibootmgr check after boot and S3: PASS * q35, IA32X64, with SMM: (06) Fedora 28 guest, efibootmgr + rdmsr checks after boot and S3: PASS (07) RHEL 7 guest, efibootmgr check after boot and S3: PASS (08) Windows 10 guest, boot and S3: PASS (09) Windows Server 2016 guest, boot: PASS (can't test S3 due to signing requirements for the QXL driver) (10) Windows 8.1 guest, boot and S3: PASS (11) Windows Server 2012 R2 guest, boot and S3: PASS (12) Windows 7 guest, boot and S3: PASS (13) Windows Server 2008 R2 guest, boot and S3: PASS Once you submit v4 with the superficial updates requested, I will add: Regression-tested-by: Laszlo Ersek I'll leave the SEV testing (with and without SMM) up to you :) Thanks! Laszlo