Re: [PATCH v2 07/11] ArmPkg: Ignore new typos reported

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Michael,

Thank you for this patch.

these changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 18/05/2022 01:13 am, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929
>
> The SpellCheck plugin began reporting new typos that were previously
> missed. Due to the number of spelling errors in this package, no
> errors are fixed in this change. They are ignored to unblock overall
> edk2 CI.
>
> The maintainers should visit the list of extended words for
> SpellCheck in ArmPkg.ci.yaml and determine the best resolution for
> each item.
>
> The following BZ was filed to track that follow up:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3929
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   ArmPkg/Drivers/ArmScmiDxe/Scmi.c                          |  2 +-
>   ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c     |  4 +-
>   ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c   |  2 +-
>   ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c |  6 +--
>   ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c       |  2 +-
>   ArmPkg/ArmPkg.ci.yaml                                     | 53 ++++++++++++++++++--
>   ArmPkg/Include/Library/OemMiscLib.h                       |  2 +-
>   7 files changed, 58 insertions(+), 13 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> index d5a1ff0be33c..f3bf08a99e76 100644
> --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
> @@ -146,7 +146,7 @@ ScmiCommandExecute (
>   /** Internal common function useful for common protocol discovery messages.
>
>     @param[in] ProtocolId    Protocol Id of the the protocol.
> -  @param[in] MesaageId     Message Id of the message.
> +  @param[in] MessageId     Message Id of the message.
>
>     @param[out] ReturnValues SCMI response return values.
>
> diff --git a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
> index 6dae7a9121af..dbd1f6c211ab 100644
> --- a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
> +++ b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c
> @@ -202,7 +202,7 @@ THUMB_INSTRUCTIONS  gOpThumb[] = {
>   };
>
>   THUMB_INSTRUCTIONS  gOpThumb2[] = {
> -  // Instruct  OpCode      OpCode Mask  Addressig Mode
> +  // Instruct  OpCode      OpCode Mask  Addressing Mode
>
>     { "ADR",    0xf2af0000, 0xfbff8000, ADR_THUMB2           }, // ADDR <Rd>, <label> ;Needs to go before ADDW
>     { "CMN",    0xf1100f00, 0xfff08f00, CMN_THUMB2           }, // CMN <Rn>, #<const> ;Needs to go before ADD
> @@ -648,7 +648,7 @@ DisassembleThumbInstruction (
>             return;
>
>           case DATA_CBZ:
> -          // CB{N}Z <Rn>, <Lable>
> +          // CB{N}Z <Rn>, <Label>
>             Target = ((OpCode >> 2) & 0x3e) | (((OpCode & BIT9) == BIT9) ? BIT6 : 0);
>             AsciiSPrint (&Buf[Offset], Size - Offset, " %a, %08x", gReg[Rd], Pc + 4 + Target);
>             return;
> diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
> index 5ff8a5b7a62e..9c9a0f1c2ef6 100644
> --- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
> +++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
> @@ -95,7 +95,7 @@ SerialPortWrite (
>   }
>
>   /**
> -  Read data from serial device and save the datas in buffer.
> +  Read data from serial device and save the data in buffer.
>
>     @param  Buffer           Point of data buffer which need to be written.
>     @param  NumberOfBytes    Number of output bytes which are cached in Buffer.
> diff --git a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
> index d55aff76201e..c61d6f7b772d 100644
> --- a/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
> +++ b/ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c
> @@ -31,7 +31,7 @@
>                                   return it contains the response parameters.
>     @param [out]      RetVal      Pointer to return the response value.
>
> -  @retval EFI_SUCCESS           Request successfull.
> +  @retval EFI_SUCCESS           Request successful.
>     @retval EFI_INVALID_PARAMETER A parameter is invalid.
>     @retval EFI_NOT_READY         Callee is busy or not in a state to handle
>                                   this request.
> @@ -134,7 +134,7 @@ SendMemoryPermissionRequest (
>     @param [in]   BaseAddress          Base address for the memory region.
>     @param [out]  MemoryAttributes     Pointer to return the memory attributes.
>
> -  @retval EFI_SUCCESS             Request successfull.
> +  @retval EFI_SUCCESS             Request successful.
>     @retval EFI_INVALID_PARAMETER   A parameter is invalid.
>     @retval EFI_NOT_READY           Callee is busy or not in a state to handle
>                                     this request.
> @@ -193,7 +193,7 @@ GetMemoryPermissions (
>     @param [in]  Length          Length of the memory region.
>     @param [in]  Permissions     Memory access controls attributes.
>
> -  @retval EFI_SUCCESS             Request successfull.
> +  @retval EFI_SUCCESS             Request successful.
>     @retval EFI_INVALID_PARAMETER   A parameter is invalid.
>     @retval EFI_NOT_READY           Callee is busy or not in a state to handle
>                                     this request.
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 98970407a65e..355d5882be31 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -36,7 +36,7 @@ OemGetCpuFreq (
>
>     @param ProcessorIndex  Index of the processor to get the information for.
>     @param ProcessorStatus Processor status.
> -  @param ProcessorCharacteristics Processor characteritics.
> +  @param ProcessorCharacteristics Processor characteristics.
>     @param MiscProcessorData        Miscellaneous processor information.
>
>     @return  TRUE on success, FALSE on failure.
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index b7e07aaef675..dccd8fd06b20 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -93,20 +93,32 @@
>           ],                           # use gitignore syntax to ignore errors
>                                        # in matching files
>           "ExtendWords": [
> -          "api's",
>             "ackintid",
>             "actlr",
>             "aeabi",
> +          "api's",
> +          "armgic",
> +          "armltd",
>             "asedis",
>             "ashldi",
>             "ashrdi",
> +          "autoreload",
>             "baddr",
> +          "batard",
> +          "bootflow",
> +          "bootup",
> +          "cacheability",
> +          "cachetype",
>             "ccidx",
>             "ccsidr",
>             "clidr",
>             "clrex",
>             "clzsi",
>             "cnthctl",
> +          "codeview",
> +          "commonlpiaff",
> +          "comms",
> +          "conout",
>             "cortexa",
>             "cpacr",
>             "cpuactlr",
> @@ -114,18 +126,21 @@
>             "ctzsi",
>             "cygdrive",
>             "cygpaths",
> -          "datas",
>             "dcmpeq",
>             "dcmpge",
>             "dcmpgt",
>             "dcmple",
>             "dcmplt",
>             "ddisable",
> +          "deadloop",
> +          "devicepath",
> +          "directlpi",
>             "divdi",
>             "divsi",
>             "dmdepkg",
>             "dpref",
>             "drsub",
> +          "everyoneelse",
>             "fcmpeq",
>             "fcmpge",
>             "fcmpgt",
> @@ -136,6 +151,7 @@
>             "hisilicon",
>             "iccabpr",
>             "iccbpr",
> +          "icceior",
>             "icciar",
>             "iccicr",
>             "icciidr",
> @@ -143,24 +159,32 @@
>             "iccpmr",
>             "iccrpr",
>             "icdabr",
> +          "icddcr",
>             "icdicer",
>             "icdicfr",
>             "icdicpr",
>             "icdictr",
>             "icdiidr",
> +          "icdipr",
> +          "icdiptr",
>             "icdiser",
>             "icdisr",
>             "icdppisr",
>             "icdsgir",
>             "icdspr",
>             "icenabler",
> +          "innershr",
>             "intid",
> +          "invall",
>             "ipriority",
>             "irouter",
>             "isenabler",
>             "istatus",
>             "itargets",
> -          "lable",
> +          "itstate",
> +          "langcode",
> +          "langcodes",
> +          "largepage",
>             "ldivmod",
>             "ldmdb",
>             "ldmia",
> @@ -174,25 +198,37 @@
>             "ldrsb",
>             "ldrsbt",
>             "ldrsh",
> +          "ldrsht",
> +          "littleendian",
>             "lshrdi",
> +          "memclr",
>             "moddi",
>             "modsi",
>             "mpcore",
>             "mpidr",
>             "muldi",
>             "mullu",
> +          "nonsecure",
>             "nonshareable",
>             "nsacr",
>             "nsasedis",
>             "nuvia",
>             "oldit",
> +          "outershr",
> +          "pagetable",
>             "pcten",
>             "plpis",
> +          "postmem",
> +          "premem",
>             "procno",
>             "readc",
> +          "reglist",
>             "revsh",
>             "rfedb",
>             "sctlr",
> +          "semihalf",
> +          "setend",
> +          "sharelvl",
>             "smccc",
>             "smlabb",
>             "smlabt",
> @@ -218,7 +254,13 @@
>             "strexd",
>             "strexh",
>             "strht",
> +          "subhierarchy",
> +          "subtrack",
> +          "subvendor",
> +          "supersection",
>             "switchu",
> +          "targetlist",
> +          "tmpname",
>             "tpidrurw",
>             "ttbcr",
>             "typer",
> @@ -232,7 +274,10 @@
>             "umodsi",
>             "usada",
>             "vlpis",
> -          "writec"
> +          "watchdogtimer",
> +          "writeback",
> +          "writec",
> +          "xectue"
>           ],                          # words to extend to the dictionary for this package
>           "IgnoreStandardPaths": [    # Standard Plugin defined paths that
>               "*.asm", "*.s"          # should be ignore
> diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h
> index 47cb30d84a62..b97c60d7507d 100644
> --- a/ArmPkg/Include/Library/OemMiscLib.h
> +++ b/ArmPkg/Include/Library/OemMiscLib.h
> @@ -83,7 +83,7 @@ OemGetCpuFreq (
>
>     @param ProcessorIndex  Index of the processor to get the information for.
>     @param ProcessorStatus Processor status.
> -  @param ProcessorCharacteristics Processor characteritics.
> +  @param ProcessorCharacteristics Processor characteristics.
>     @param MiscProcessorData        Miscellaneous processor information.
>
>     @return  TRUE on success, FALSE on failure.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.