From: "Lendacky, Thomas" <thomas.lendacky@amd.com>
To: devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Rahul Kumar <rahul1.kumar@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Garrett Kirkendall <garrett.kirkendall@amd.com>
Subject: [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure
Date: Wed, 23 Sep 2020 13:04:00 -0500 [thread overview]
Message-ID: <21345cdbc906519558202b3851257ca07b9239ba.1600884239.git.thomas.lendacky@amd.com> (raw)
From: Tom Lendacky <thomas.lendacky@amd.com>
The AP reset vector stack allocation is only required if running as an
SEV-ES guest. Since the reset vector allocation is below 1MB in memory,
eliminate the requirement for bare-metal systems and non SEV-ES guests
to allocate the extra stack area, which can be large if the
PcdCpuMaxLogicalProcessorNumber value is large, and also remove the
CPU_STACK_ALIGNMENT alignment.
Fixes: 7b7508ad784d ("UefiCpuPkg: Allow AP booting under SEV-ES")
Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 36 +++++++++-----------
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index 07426274f639..a9708c6479d2 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -1141,20 +1141,6 @@ RestoreWakeupBuffer(
);
}
-/**
- Calculate the size of the reset stack.
-
- @return Total amount of memory required for stacks
-**/
-STATIC
-UINTN
-GetApResetStackSize (
- VOID
- )
-{
- return AP_RESET_STACK_SIZE * PcdGet32(PcdCpuMaxLogicalProcessorNumber);
-}
-
/**
Calculate the size of the reset vector.
@@ -1170,11 +1156,23 @@ GetApResetVectorSize (
{
UINTN Size;
- Size = ALIGN_VALUE (AddressMap->RendezvousFunnelSize +
- AddressMap->SwitchToRealSize +
- sizeof (MP_CPU_EXCHANGE_INFO),
- CPU_STACK_ALIGNMENT);
- Size += GetApResetStackSize ();
+ Size = AddressMap->RendezvousFunnelSize +
+ AddressMap->SwitchToRealSize +
+ sizeof (MP_CPU_EXCHANGE_INFO);
+
+ //
+ // The AP reset stack is only used by SEV-ES guests. Do not add to the
+ // allocation if SEV-ES is not enabled.
+ //
+ if (PcdGetBool (PcdSevEsIsEnabled)) {
+ //
+ // Stack location is based on APIC ID, so use the total number of
+ // processors for calculating the total stack area.
+ //
+ Size += AP_RESET_STACK_SIZE * PcdGet32(PcdCpuMaxLogicalProcessorNumber);
+
+ Size = ALIGN_VALUE (Size, CPU_STACK_ALIGNMENT);
+ }
return Size;
}
--
2.28.0
next reply other threads:[~2020-09-23 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 18:04 Lendacky, Thomas [this message]
2020-09-24 6:22 ` [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure Laszlo Ersek
2020-09-24 13:30 ` Lendacky, Thomas
2020-09-24 15:03 ` Laszlo Ersek
2020-10-02 16:42 ` Lendacky, Thomas
2020-10-19 15:02 ` Lendacky, Thomas
2020-10-19 21:51 ` Laszlo Ersek
2020-09-25 16:09 ` [edk2-devel] " Brian J. Johnson
2020-09-25 16:52 ` Lendacky, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21345cdbc906519558202b3851257ca07b9239ba.1600884239.git.thomas.lendacky@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox