From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::443; helo=mail-pf1-x443.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8176210D851D for ; Sun, 5 Aug 2018 08:11:27 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id x17-v6so5598419pfh.5 for ; Sun, 05 Aug 2018 08:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=IP9N4FGCEMXvKuJSYi35r13UIFgy3yWI5u9JWUpwW6c=; b=GAAfpaTAVMMDntX/BpJW8C4mqtqTilyrFYdKbXt5sDlMcj5avGqsjO2UaWH1IlZnBx NMLBP7h6IS20oF7dG1dpl9j645h5y0XzK9/+RrbpHFlammsCJ/GI+rfrHHt4EcuOomw2 6cyYaa6Y1X5OMGVKzoFHEuEyzdj2492LlkGnc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=IP9N4FGCEMXvKuJSYi35r13UIFgy3yWI5u9JWUpwW6c=; b=dUAQL5wiKbHiTUYXTJBTBCmQDFmtx7NzJnw88yOXmsSJcymTH5J1GJaE7Es2ED+PDr /4CfWrajBHeAp3/ImDgUnPe2ladeW608Z5EQ4HcQxZjvjeGxuFNQKFIdhXTL229dOxqX LznAEPU3NgGPNM65vrJnXTrnudxzx21gms0lutomRKZareiXzOPosFVyTlX6KOWmOkev uhd6gTklXIVCaoB+VkTeqe9CKQt7eQjc4XNUXYeSrcthSXDxmgPXYZRzojIhz7oygaV0 +3GXTVMgbmoozWmj2MjDbhAsHSwyAB/XhHX1jTy0Psb8rCVoOEr8kwLuRbuOs4rnbdCT UtrQ== X-Gm-Message-State: AOUpUlGuhkkFT3nDQCB1AiiORUkI+EVKkHGt2zNbYjDnhKCupZ8MqIXr mUFYfExnqd//xJBMpFvQ3xztPQ== X-Google-Smtp-Source: AAOMgpcPstq1h8IGVo86lBRQSj653D7yXVGVX2fsAjfAEYFENQ6GxYxWSJ0DZkI8MCh+E76XeH8m1Q== X-Received: by 2002:a63:ea0c:: with SMTP id c12-v6mr11389901pgi.158.1533481887332; Sun, 05 Aug 2018 08:11:27 -0700 (PDT) Received: from [10.67.1.170] ([64.64.108.17]) by smtp.gmail.com with ESMTPSA id q85-v6sm15271657pfa.151.2018.08.05.08.11.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Aug 2018 08:11:26 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, Zhou You References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-3-ming.huang@linaro.org> <20180802145636.o4qgzlmx44s4ttcm@bivouac.eciton.net> From: Ming Message-ID: <214865a5-9504-e912-9c01-3fe6b7b9566f@linaro.org> Date: Sun, 5 Aug 2018 23:11:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180802145636.o4qgzlmx44s4ttcm@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 02/38] Silicon/Hisilicon: Separate PlatformArch.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2018 15:11:27 -0000 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit ÔÚ 8/2/2018 10:56 PM, Leif Lindholm дµÀ: > On Tue, Jul 24, 2018 at 03:08:46PM +0800, Ming Huang wrote: >> As the mocro of PlatformArch.h is platform special, so Separate > > mocro -> macro (typo) > special -> specific (subtleties of English language :) > Separate -> separate (case) > >> PlatformArch.h to Hi1610,Hi1616,Hi1620 for unifying D0x. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Zhou You >> Signed-off-by: Ming Huang >> --- >> Silicon/Hisilicon/{ => Hi1610}/Include/PlatformArch.h | 0 >> Silicon/Hisilicon/Hi1616/Include/PlatformArch.h | 35 ++++++++++++++++++++ >> Silicon/Hisilicon/Hi1620/Include/PlatformArch.h | 34 +++++++++++++++++++ > > Could you move the Hi1620 file to the "add d06 base files" patch? > There is nothing else for D06 in the tree at this point. > (Don't forget to update comment to reflect.) > Yes, Hi1620 file will be move to the "add d06 base files" patch. >> 3 files changed, 69 insertions(+) >> >> diff --git a/Silicon/Hisilicon/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1610/Include/PlatformArch.h >> similarity index 100% >> rename from Silicon/Hisilicon/Include/PlatformArch.h >> rename to Silicon/Hisilicon/Hi1610/Include/PlatformArch.h >> diff --git a/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h >> new file mode 100644 >> index 0000000000..45995c5893 >> --- /dev/null >> +++ b/Silicon/Hisilicon/Hi1616/Include/PlatformArch.h >> @@ -0,0 +1,35 @@ >> +/** @file >> +* >> +* Copyright (c) 2015, Hisilicon Limited. All rights reserved. >> +* Copyright (c) 2015, Linaro Limited. All rights reserved. > > Update copyright year? > >> +* >> +* This program and the accompanying materials >> +* are licensed and made available under the terms and conditions of the BSD License >> +* which accompanies this distribution. The full text of the license may be found at >> +* http://opensource.org/licenses/bsd-license.php >> +* >> +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> +* >> +**/ >> + >> + >> + >> +#ifndef _PLATFORM_ARCH_H_ >> +#define _PLATFORM_ARCH_H_ >> + >> +#define MAX_SOCKET 2 >> +#define MAX_DIE 4 >> +#define MAX_DDRC 2 >> +#define MAX_NODE (MAX_SOCKET * MAX_DIE) >> +#define MAX_CHANNEL 4 >> +#define MAX_DIMM 3 >> +#define MAX_RANK_CH 12 >> +#define MAX_RANK_DIMM 4 >> +// Max NUMA node number for each node type >> +#define MAX_NUM_PER_TYPE 8 >> + >> +#define S1_BASE 0x40000000000 >> + >> +#endif >> + >> diff --git a/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h >> new file mode 100644 >> index 0000000000..7243a9ec35 >> --- /dev/null >> +++ b/Silicon/Hisilicon/Hi1620/Include/PlatformArch.h >> @@ -0,0 +1,34 @@ >> +/** @file >> +* >> +* Copyright (c) 2015, Hisilicon Limited. All rights reserved. >> +* Copyright (c) 2015, Linaro Limited. All rights reserved. > > Update copyright year? (in other patch) > > / > Leif > Ok, I will check all patches. Ming >> +* >> +* This program and the accompanying materials >> +* are licensed and made available under the terms and conditions of the BSD License >> +* which accompanies this distribution. The full text of the license may be found at >> +* http://opensource.org/licenses/bsd-license.php >> +* >> +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> +* >> +**/ >> + >> + >> + >> +#ifndef _PLATFORM_ARCH_H_ >> +#define _PLATFORM_ARCH_H_ >> + >> +#define MAX_SOCKET 2 >> +#define MAX_DIE 4 >> +#define MAX_DDRC 4 >> +#define MAX_NODE (MAX_SOCKET * MAX_DIE) >> +#define MAX_CHANNEL 8 >> +#define MAX_DIMM 2 >> +#define MAX_RANK_CH 8 >> +#define MAX_RANK_DIMM 4 >> +// Max NUMA node number for each node type >> +#define MAX_NUM_PER_TYPE 8 >> + >> + >> +#endif >> + >> -- >> 2.17.0 >>