From: "Laszlo Ersek" <lersek@redhat.com>
To: Hao A Wu <hao.a.wu@intel.com>, devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency
Date: Wed, 22 Apr 2020 18:14:48 +0200 [thread overview]
Message-ID: <2156a083-1796-9fe6-7f18-894fb779b823@redhat.com> (raw)
In-Reply-To: <20200422065549.10880-1-hao.a.wu@intel.com>
On 04/22/20 08:55, Hao A Wu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
>
> Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
> none of them list the dependency of the PcdLib in INF & header files.
>
> This commit will explicitly add such dependency in .H and .INF files.
>
> Test done:
> Library level build pass for VS2015x86 tool chain
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> index a51a9ec1d2..9907f4157b 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> @@ -51,6 +51,7 @@ [LibraryClasses]
> UefiBootServicesTableLib
> DebugAgentLib
> SynchronizationLib
> + PcdLib
>
> [Protocols]
> gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> index d78d328b42..89ee9a79d8 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> @@ -50,6 +50,7 @@ [LibraryClasses]
> UefiCpuLib
> SynchronizationLib
> PeiServicesLib
> + PcdLib
>
> [Pcd]
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 74e919dae0..a8ca03efb8 100755
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -31,6 +31,7 @@
> #include <Library/SynchronizationLib.h>
> #include <Library/MtrrLib.h>
> #include <Library/HobLib.h>
> +#include <Library/PcdLib.h>
>
> #include <Guid/MicrocodePatchHob.h>
>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2020-04-22 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 6:55 [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Wu, Hao A
2020-04-22 8:10 ` [edk2-devel] " Ni, Ray
2020-04-22 16:14 ` Laszlo Ersek [this message]
2020-04-23 8:50 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2156a083-1796-9fe6-7f18-894fb779b823@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox