From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.5629.1587572099063461204 for ; Wed, 22 Apr 2020 09:14:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qo5lirzn; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587572097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QOyDsJ62HbGED/NHd733VZ8thswXnlTPsgKg+zxWswY=; b=Qo5lirzno7Tjr9T4fkgRs5nxV4HFThTrEdBUswAaZgko0IJdQ2rrNLvsiQfw4tER+ZyLRI ZzlqrSoYiQEla7jDDOpZa+X2BpiRenJhc+qRHT/yowqkI0vUI8tf5c4gtPyM7O/lbIIkFe F2brtL2XhnOtSyQO3OzwnzRKHkNboTQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-mMk9GAujNRq9TVCa_vUzZw-1; Wed, 22 Apr 2020 12:14:51 -0400 X-MC-Unique: mMk9GAujNRq9TVCa_vUzZw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D9371052512; Wed, 22 Apr 2020 16:14:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3792D5EDE1; Wed, 22 Apr 2020 16:14:49 +0000 (UTC) Subject: Re: [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency To: Hao A Wu , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: <20200422065549.10880-1-hao.a.wu@intel.com> From: "Laszlo Ersek" Message-ID: <2156a083-1796-9fe6-7f18-894fb779b823@redhat.com> Date: Wed, 22 Apr 2020 18:14:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200422065549.10880-1-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/22/20 08:55, Hao A Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632 > > Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but > none of them list the dependency of the PcdLib in INF & header files. > > This commit will explicitly add such dependency in .H and .INF files. > > Test done: > Library level build pass for VS2015x86 tool chain > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Hao A Wu > --- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > index a51a9ec1d2..9907f4157b 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > @@ -51,6 +51,7 @@ [LibraryClasses] > UefiBootServicesTableLib > DebugAgentLib > SynchronizationLib > + PcdLib > > [Protocols] > gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > index d78d328b42..89ee9a79d8 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > @@ -50,6 +50,7 @@ [LibraryClasses] > UefiCpuLib > SynchronizationLib > PeiServicesLib > + PcdLib > > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h > index 74e919dae0..a8ca03efb8 100755 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include > > Reviewed-by: Laszlo Ersek