From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web10.92207.1684164815174380868 for ; Mon, 15 May 2023 08:33:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=NzKHiPWR; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DE5F53200904; Mon, 15 May 2023 11:33:33 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute5.internal (MEProxy); Mon, 15 May 2023 11:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1684164813; x=1684251213; bh=TtiM88VV/b8DzdNRthi11hLdz+WlcerNHoS 2qbei11Q=; b=NzKHiPWR5irwJXQvMS41XDf+GTZSZMUYmzKVZu3bBWXoUh0sdON JVVTA2qaP/mCF+57MCg3a+PX4AvOJRVg27tz/FEUryQLSUMpGU4QdPRg83UmejE1 Q1na9pawJ+EksGuHXiSdTDM530AcsiI8H7uVgtG6y7ym2zq9Yjy0mBhg7kNoxPJM Mc6VDnnArURce0UO6aoEK5FhGLqV+sJcvBlq5s0l+KiXvjN7GaT6BO0rHI1C96KO h+DsX7OchcO9pQ19rrx9T4kPtENu6OXvAS7hF21G2uNfh2T02kUIDwsVoU6C18Aq w2oYQhiCvbSNqiXywMAy/BelkB+IHKhOHRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684164813; x=1684251213; bh=TtiM88VV/b8DzdNRthi11hLdz+WlcerNHoS 2qbei11Q=; b=U0N1ajocblFIHyOAvQmttwXMHmqFwwxzc+9uvTofldABn1pLSzJ TTBcLG9JyfxWmpwD7aTCD4Omma03mtLA2YyduTnoA0KEgcGPYT+8m3VvKEg8zSB5 pYQ4mp60NyOg5cJge3fi6o32/vg7Hbx9qDr7GGP9t7XBpnO2vQ2jvjPo/5/Nw3tk cnvgS/trjElSoNT67qHy5jPLJQKT6biFD3Y7RPoDQdJ9QK+IGGJHFEj8k7rPYFng TdztBH8bwButeelt4wZrnTcqPGmO3N3f17oz/DayCfHrRbc0HCtMwXAgs/h08x6t 60SZnxOa9CFOrjRCVIohTnteo5eoPKIlq5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehjedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdft vggsvggttggrucevrhgrnhdfuceorhgvsggvtggtrgessghsughiohdrtghomheqnecugg ftrfgrthhtvghrnheptdehgfekheejueekfefhhfffteevffekjeehffejhfeijeetgeei hfekgfetuddtnecuffhomhgrihhnpehgrhhouhhpshdrihhonecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdr tghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id ED8CA2D4008F; Mon, 15 May 2023 11:33:32 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-415-gf2b17fe6c3-fm-20230503.001-gf2b17fe6 Mime-Version: 1.0 Message-Id: <215e3e62-8302-40ca-bc91-d8e7071bfe20@app.fastmail.com> In-Reply-To: References: <20230515144539.176967-1-pedro.falcato@gmail.com> <9bc20ea6-3bb6-8b13-ea9f-790bcbed71ea@bsdio.com> <43C66EEC-4489-4D1D-B345-04CC7AB83670@posteo.de> Date: Mon, 15 May 2023 09:33:32 -0600 From: "Rebecca Cran" To: devel@edk2.groups.io, pedro.falcato@gmail.com, =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: "Kinney, Michael D" , gaoliming , "'Zhiguang Liu'" , "Gerd Hoffmann" Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Base.h: Simply alignment expressions Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable I wasn=E2=80=99t aware of the history, so I agree with keeping it. =E2=80=94=20 Rebecca Cran On Mon, May 15, 2023, at 9:29 AM, Pedro Falcato wrote: > On Mon, May 15, 2023 at 4:20=E2=80=AFPM Marvin H=C3=A4user wrote: >> >> Well, I explicitly added this macro as a prerequisite to code used in ou= r new PE library (remember this patch was initially sent in 2021). We still= require it downstream, but obviously upstream is not interested in the rel= ated contributions that were to follow at the time. >> >> Gerd picked it up because he wanted to attempt to re-try contributing th= e new PE library, but I haven't heard from him in weeks. >> >> Design-wise, I agree it could be removed again. However, there first was= a downstream burden when adding it (as we needed to rewrite our history to= drop our downstream patch in favour of the upstream solution). Now introdu= cing another downstream burden *again* to remove the macro that was added o= nly a few weeks back would be a sign of poor management and planning. > > I don't agree with the removal of the macro. It's useful enough to > consumers of Base.h, and clearly there's code that is indeed actively > using it. > > It's also a single line of code. > > --=20 > Pedro > > >=20