From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=SPF record not found (domain: fensystems.co.uk, ip: 212.13.204.60, mailfrom: mbrown@fensystems.co.uk)
Received: from duck.fensystems.co.uk (duck.fensystems.co.uk [212.13.204.60])
 by groups.io with SMTP; Wed, 24 Jul 2019 13:53:03 -0700
Received: from pudding.home (cbs92326-cmbg19-2-0-cust10.5-4.cable.virginm.net [86.1.148.75])
	by duck.fensystems.co.uk (Postfix) with ESMTPSA id A714515D29;
	Wed, 24 Jul 2019 21:53:00 +0100 (BST)
Subject: Re: [edk2-devel] [edk2-platforms: PATCHv2 1/1] Platform/RPi3: Provide "ethernet[0]" aliases in device tree
To: devel@edk2.groups.io, leif.lindholm@linaro.org
Cc: ard.biesheuvel@linaro.org, pete@akeo.ie
References: <20190723111727.GG11541@bivouac.eciton.net>
 <20190724143114.468304-2-mbrown@fensystems.co.uk>
 <20190724185343.GX11541@bivouac.eciton.net>
From: Michael Brown <mbrown@fensystems.co.uk>
Message-ID: <2165bfd9-d097-cd1d-0302-7c541f7f63cb@fensystems.co.uk>
Date: Wed, 24 Jul 2019 21:53:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190724185343.GX11541@bivouac.eciton.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit

On 24/07/2019 19:53, Leif Lindholm wrote:
>>     SanitizePSCI ();
>>     CleanMemoryNodes ();
>>     CleanSimpleFramebuffer ();
>> +  FixEthernetAliases ();
> 
> ...would it be worth having a return value here and Print()ing a
> message visible regardless of build profile if this function fails?

Yes, I think that would be very sensible, but it would also be 
inconsistent with the rest of the code: all of the other 
device-tree-modifying functions in FdtDxe.c are declared as VOID and use 
only DEBUG to report errors.

Changing this pattern throughout FdtDxe.c should, I think, be a 
completely separate patch.  Would it be possible to merge the current 
patch, and I can then follow up with a second patch to improve the error 
visibility in non-debug builds?

Thanks,

Michael