From: "Sean" <sean.brogan@microsoft.com>
To: Guomin Jiang <guomin.jiang@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.
Date: Tue, 07 Apr 2020 22:59:46 -0700 [thread overview]
Message-ID: <21667.1586325586008188182@groups.io> (raw)
In-Reply-To: <DM6PR11MB2955D38B51E522EA2A6A48199DC00@DM6PR11MB2955.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
Guomin,
Can you speak to why you implemented differently than the suggested and validated patch? Seems you created a local whereas ours just used the internal data member.
Thanks
sean
[-- Attachment #2: Type: text/html, Size: 230 bytes --]
next prev parent reply other threads:[~2020-04-08 5:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <160150CCACE2328E.16021@groups.io>
2020-04-08 5:29 ` [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer Guomin Jiang
2020-04-08 5:59 ` Sean [this message]
2020-04-09 1:29 ` Guomin Jiang
2020-04-10 7:17 ` Kun Qin
2020-04-13 6:20 ` Guomin Jiang
2020-04-13 6:47 ` Kun Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21667.1586325586008188182@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox