public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Songpeng Li <songpeng.li@intel.com>, edk2-devel@lists.01.org
Cc: Siyuan Fu <siyuan.fu@intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>
Subject: Re: [PATCH] NetworkPkg: Remove the redundant code and definition.
Date: Tue, 14 Aug 2018 17:14:55 +0200	[thread overview]
Message-ID: <216ed987-ae29-2620-e596-b772866b126d@redhat.com> (raw)
In-Reply-To: <20180813024519.5704-1-songpeng.li@intel.com>

On 08/13/18 04:45, Songpeng Li wrote:
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1064
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Songpeng Li <songpeng.li@intel.com>
> ---
>  NetworkPkg/IScsiDxe/IScsiDxe.inf     |  1 -
>  NetworkPkg/IScsiDxe/IScsiProto.c     | 33 ------------
>  NetworkPkg/IpSecDxe/Ikev2/Payload.c  | 18 -------
>  NetworkPkg/IpSecDxe/Ikev2/Utility.c  | 76 ----------------------------
>  NetworkPkg/IpSecDxe/Ikev2/Utility.h  | 67 ------------------------
>  NetworkPkg/TcpDxe/TcpOption.c        | 30 -----------
>  NetworkPkg/TcpDxe/TcpOption.h        | 16 ------
>  NetworkPkg/TlsDxe/TlsDxe.inf         |  1 -
>  NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 23 ---------
>  NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.h | 10 ----
>  10 files changed, 275 deletions(-)

Nacked-by: Laszlo Ersek <lersek@redhat.com>


Please fragment the patch to a series so that each patch modify only one
module under NetworkPkg. References:

http://mid.mail-archive.com/4A89E2EF3DFEDB4C8BFDE51014F606A14E2C6745@SHSMSX104.ccr.corp.intel.com

http://mid.mail-archive.com/20180808084712.34696-1-shenglei.zhang@intel.com

Laszlo


  parent reply	other threads:[~2018-08-14 15:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13  2:45 [PATCH] NetworkPkg: Remove the redundant code and definition Songpeng Li
2018-08-13  4:42 ` Fu, Siyuan
2018-08-14 15:14 ` Laszlo Ersek [this message]
2018-08-15  0:45 ` Wu, Jiaxin
     [not found] <20180809083322.7888-1-songpeng.li@intel.com>
2018-08-13  4:43 ` Fu, Siyuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=216ed987-ae29-2620-e596-b772866b126d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox