Hi Duke,
Besides the AMD copyright is put in an improper place. I also found that there are several #include guards that don't follow edk2 C coding standard. There are several trailing underscores (like four underscores) attached to the macro. Please just put one trailing underscore as "INCLUDE_GUARD_".

Please send out V3 with the fixes.
Thanks
Abenr


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114571): https://edk2.groups.io/g/devel/message/114571
Mute This Topic: https://groups.io/mt/103971387/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-