Hi Duke,<br />Besides the AMD copyright is put in an improper place. I also found that there are several #include guards that don't follow edk2 C coding standard. There are several trailing underscores (like four underscores) attached to the macro. Please just put one trailing underscore as "INCLUDE_GUARD_".<br /><br />Please send out V3 with the fixes.<br />Thanks<br />Abenr


<div width="1" style="color:white;clear:both">_._,_._,_</div>
<hr>


Groups.io Links:<p>


  
    You receive all messages sent to this group.
  
  


<p>
<a target="_blank" href="https://edk2.groups.io/g/devel/message/114571">View/Reply Online (#114571)</a> |


  

|

  <a target="_blank" href="https://groups.io/mt/103971387/7686176">Mute This Topic</a>


| <a href="https://edk2.groups.io/g/devel/post">New Topic</a>

<br>




<a href="https://edk2.groups.io/g/devel/editsub/7686176">Your Subscription</a> |
<a href="mailto:devel+owner@edk2.groups.io">Contact Group Owner</a> |

<a href="https://edk2.groups.io/g/devel/unsub">Unsubscribe</a>

 [rebecca@openfw.io]<br>
<div width="1" style="color:white;clear:both">_._,_._,_</div>