From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 416DAD811B0 for ; Fri, 26 Jan 2024 09:48:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=G86VcaTFAemljFv6gjyEl1kTtTKjoBBjY7JvlJR0xks=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1706262505; v=1; b=booZvc5vQwQqj42/pJAX+6X1RlJ5Jef+MbeeZ7AOo0jTOpUz4X8KfEQd9Wbyp9Cqwv815Vbv BdtLu682tPoGItFT9ueyJJVTD4caAdSBM2wETkfvMLdmZNVilBT5ThXuKz0VbVGawZgYBX08EcW nVzjdXOK2bA0we1AdKjhIi9g= X-Received: by 127.0.0.2 with SMTP id HJ9lYY7687511xS7sTuynTpg; Fri, 26 Jan 2024 01:48:25 -0800 Subject: Re: [edk2-devel] [PATCH V2 00/32] Introduce AMD Vangogh platform reference code To: Zhai, MingXin (Duke) ,devel@edk2.groups.io From: "Chang, Abner via groups.io" X-Originating-Location: Plano, Texas, US (161.69.88.44) X-Originating-Platform: Windows Chrome 120 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 26 Jan 2024 01:48:25 -0800 References: <20240126060050.1725-1-duke.zhai@amd.com> In-Reply-To: <20240126060050.1725-1-duke.zhai@amd.com> Message-ID: <21740.1706262505278827599@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9lrBvMEdHrUTfwOMoytYlhFfx7686176AA= Content-Type: multipart/alternative; boundary="A8pYHrOA7AQabxy8O1Po" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=booZvc5v; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --A8pYHrOA7AQabxy8O1Po Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Duke, Besides the AMD copyright is put in an improper place. I also found that th= ere are several #include guards that don't follow edk2 C coding standard. T= here are several trailing underscores (like four underscores) attached to t= he macro. Please just put one trailing underscore as "INCLUDE_GUARD_". Please send out V3 with the fixes. Thanks Abenr -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114571): https://edk2.groups.io/g/devel/message/114571 Mute This Topic: https://groups.io/mt/103971387/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --A8pYHrOA7AQabxy8O1Po Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Duke,
Besides the AMD copyright is put in an improper place. I also= found that there are several #include guards that don't follow edk2 C codi= ng standard. There are several trailing underscores (like four underscores)= attached to the macro. Please just put one trailing underscore as "INCLUDE= _GUARD_".

Please send out V3 with the fixes.
Thanks
Ab= enr
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#114571) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--A8pYHrOA7AQabxy8O1Po--