From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Dandan Bi <dandan.bi@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [patch V4 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access
Date: Tue, 30 Mar 2021 09:47:57 -0700 [thread overview]
Message-ID: <21795.1617122877940514482@groups.io> (raw)
In-Reply-To: <20210328120229.24828-29-dandan.bi@intel.com>
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
Hi Dandan,
On Sun, Mar 28, 2021 at 05:03 AM, Dandan Bi wrote:
>
> + Flag = FilterBeforeMmIoRead (FilterWidth8, Address, &Value);
> + if (Flag {
There is a missing closing bracket here and at other places in MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c. Can you check, please?
>
> + Value = *(volatile UINT8*)Address;
> + }
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 443 bytes --]
next prev parent reply other threads:[~2021-03-30 16:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 12:02 [patch V4 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-28 12:02 ` [patch V4 01/29] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-28 12:02 ` [patch V4 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg Dandan Bi
2021-03-28 12:02 ` [patch V4 03/29] ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-30 20:55 ` [edk2-devel] " Sami Mujawar
2021-03-28 12:02 ` [patch V4 04/29] ArmPlatformPkg: " Dandan Bi
2021-03-30 20:55 ` [edk2-devel] " Sami Mujawar
2021-03-28 12:02 ` [patch V4 05/29] ArmVirtPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 06/29] CryptoPkg: " Dandan Bi
2021-03-28 13:02 ` Yao, Jiewen
2021-03-28 12:02 ` [patch V4 07/29] DynamicTablesPkg: " Dandan Bi
2021-03-30 20:25 ` Sami Mujawar
2021-03-28 12:02 ` [patch V4 08/29] EmbeddedPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 09/29] EmulatorPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 10/29] FatPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 11/29] FmpDevicePkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 12/29] IntelFsp2Pkg: " Dandan Bi
2021-03-29 0:26 ` Chiu, Chasel
2021-03-28 12:02 ` [patch V4 13/29] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-29 0:26 ` Chiu, Chasel
2021-03-28 12:02 ` [patch V4 14/29] MdeModulePkg: " Dandan Bi
2021-03-29 3:12 ` Wu, Hao A
2021-03-28 12:02 ` [patch V4 15/29] MdePkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 16/29] NetworkPkg: " Dandan Bi
2021-03-30 1:28 ` Wu, Jiaxin
2021-04-01 14:27 ` [edk2-devel] " Maciej Rabeda
2021-03-28 12:02 ` [patch V4 17/29] OvmfPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 18/29] PcAtChipsetPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 19/29] RedfishPkg: " Dandan Bi
2021-03-29 1:55 ` Abner Chang
2021-03-28 12:02 ` [patch V4 20/29] SecurityPkg: " Dandan Bi
2021-03-28 13:02 ` Yao, Jiewen
2021-03-28 12:02 ` [patch V4 21/29] ShellPkg: " Dandan Bi
2021-03-29 5:30 ` Gao, Zhichao
2021-03-28 12:02 ` [patch V4 22/29] SignedCapsulePkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 23/29] SourceLevelDebugPkg: " Dandan Bi
2021-03-29 3:12 ` Wu, Hao A
2021-03-29 3:14 ` [edk2-devel] " Wu, Hao A
2021-03-29 3:12 ` Wu, Hao A
2021-03-28 12:02 ` [patch V4 24/29] StandaloneMmPkg: " Dandan Bi
2021-03-28 13:01 ` Yao, Jiewen
2021-03-30 20:55 ` Sami Mujawar
2021-03-28 12:02 ` [patch V4 25/29] UefiCpuPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 26/29] UefiPayloadPkg: " Dandan Bi
2021-03-29 3:52 ` Ma, Maurice
2021-03-28 12:02 ` [patch V4 27/29] UnitTestFrameworkPkg: " Dandan Bi
2021-03-28 12:02 ` [patch V4 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-30 16:47 ` Sami Mujawar [this message]
2021-03-31 1:14 ` [edk2-devel] " Dandan Bi
2021-03-28 12:02 ` [patch V4 29/29] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
2021-03-30 1:55 ` [patch V4 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21795.1617122877940514482@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox