From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [patch V4 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access
To: Dandan Bi <dandan.bi@intel.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: GB (217.140.99.251)
X-Originating-Platform: Windows Firefox 87
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Tue, 30 Mar 2021 09:47:57 -0700
References: <20210328120229.24828-29-dandan.bi@intel.com>
In-Reply-To: <20210328120229.24828-29-dandan.bi@intel.com>
Message-ID: <21795.1617122877940514482@groups.io>
Content-Type: multipart/alternative; boundary="JdXXfqRM8IzTLUQ459pH"

--JdXXfqRM8IzTLUQ459pH
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Dandan,

On Sun, Mar 28, 2021 at 05:03 AM, Dandan Bi wrote:

>=20
> + Flag =3D FilterBeforeMmIoRead (FilterWidth8, Address, &Value);
> + if (Flag {

There is a missing closing bracket here and at other places in MdePkg/Libr=
ary/BaseIoLibIntrinsic/IoLibNoIo.c. Can you check, please?

>=20
> + Value =3D *(volatile UINT8*)Address;
> + }

Regards,

Sami Mujawar

--JdXXfqRM8IzTLUQ459pH
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Dandan,<br /><br />On Sun, Mar 28, 2021 at 05:03 AM, Dandan Bi wrote:<br=
 />
<blockquote>+ Flag =3D FilterBeforeMmIoRead (FilterWidth8, Address, &amp;V=
alue);<br />+ if (Flag {</blockquote>
There is a missing closing bracket here and at other places in MdePkg/Libr=
ary/BaseIoLibIntrinsic/IoLibNoIo.c. Can you check, please?<br /><br />
<blockquote>+ Value =3D *(volatile UINT8*)Address;<br />+ }</blockquote>
Regards,<br /><br />Sami Mujawar

--JdXXfqRM8IzTLUQ459pH--