From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 54A797803D2 for ; Fri, 13 Oct 2023 20:42:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zx+G4Akoy55HXM5kBWJFqNXyL7lgsh0zScN75tlpE5A=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697229750; v=1; b=n//XZ/J5Z89b3SlV1oEPc4s7Aka4cvbaCucQcfz8HhAiw/Dj9kgyAL4D6bYXI6XWBu7p8qc0 gPvJOmtL8Gtr7a3fmSUF9zChh4lfxIYtans3/ZNC/TOhcDYQi8yigAepmUACIm21HkkUtFCiPKp 1LwNTLX4J/XfRjzFjFO/MffU= X-Received: by 127.0.0.2 with SMTP id LkBCYY7687511xLPmm5ehhGo; Fri, 13 Oct 2023 13:42:30 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.49597.1697229750232094890 for ; Fri, 13 Oct 2023 13:42:30 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-73-Z1kSoDRdMHCH7AiD3KDBUw-1; Fri, 13 Oct 2023 16:42:20 -0400 X-MC-Unique: Z1kSoDRdMHCH7AiD3KDBUw-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8062185A795; Fri, 13 Oct 2023 20:42:19 +0000 (UTC) X-Received: from [10.39.192.13] (unknown [10.39.192.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B93B1130514; Fri, 13 Oct 2023 20:42:15 +0000 (UTC) Message-ID: <21b719b1-d59e-d12f-c19d-d604e2d2f991@redhat.com> Date: Fri, 13 Oct 2023 22:42:14 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped To: Ard Biesheuvel , devel@edk2.groups.io Cc: Ard Biesheuvel , Bibo Mao , Chao Li , Chuong Tran , Leif Lindholm , Ling Jia , Marcin Wojtas , Masami Hiramatsu , Meenakshi Aggarwal , Nhi Pham , Peng Xie , Rebecca Cran , Wenyi Xie , Xianglai li , Yiqi Shu References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EZ9Ibi7PWeExjuLbbT24W1u2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="n//XZ/J5"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/13/23 12:12, Ard Biesheuvel wrote: > On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote: >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D4564 >> >> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly >> declares a function called LibRtcVirtualNotifyEvent(). No component ever >> calls this function across module boundaries; all RealTimeClockLib >> instances in edk2 and edk2-platforms are supposed to register -- and do >> register -- their SetVirtualAddressMap() notification functions. >> >> In a sibling series for edk2, we're going to remove the >> LibRtcVirtualNotifyEvent() API from the RealTimeClockLib *class* header. >> In edk2-platforms, that means the following: >> >> (1) Fix existent (independent) build failures / bitrot. This is a >> pre-requisite for showing that the other changes don't regress the >> build. Build regression testing is only possible if you have a build >> that completes in the first place. >> >> Patch #1 enables the NOOPT target for Hisilicon platforms, so that they >> can be more quickly built: Hisilicon needs several fixes for existent >> build issues. Patches #2 through #7 fix those issues. >> >> In particular patch#4 ("Hisilicon: rename OemMiscLib class to >> HisiOemMiscLib") requires an ek2-non-osi complement; please see that in >> the sibling edk2-non-osi posting ("Hisilicon: rename OemMiscLib class >> dependencies to HisiOemMiscLib"). >> >> Patch #12 fixes prior build breakage in AmpereAltraPkg. >> >> (2) In those RealTimeClockLib instances that define >> LibRtcVirtualNotifyEvent(), demonstrate that either (a) the usage is >> module-internal, or (b) there is no usage. >> >> In case (a), rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), >> and make it static. If needed, hoist the function definition above the >> reference. In case (b), remove the function definition. >> >> (3) Some affected RealTimeClockLib instances turn out to be entirely >> unused / superfluous; drop those altogether. >> >> Cc: Ard Biesheuvel >> Cc: Bibo Mao >> Cc: Chao Li >> Cc: Chuong Tran >> Cc: Leif Lindholm >> Cc: Ling Jia >> Cc: Marcin Wojtas >> Cc: Masami Hiramatsu >> Cc: Meenakshi Aggarwal >> Cc: Nhi Pham >> Cc: Peng Xie >> Cc: Rebecca Cran >> Cc: Wenyi Xie >> Cc: Xianglai li >> Cc: Yiqi Shu >> >> Thanks >> Laszlo >> >> Laszlo Ersek (19): >> Hisilicon: enable NOOPT builds >> Hisilicon/FlashFvbDxe: fix PcdNorFlashCheckBlockLocked token space >> GUID >> Hisilicon.dsc.inc: resolve VariableFlashInfoLib >> Hisilicon: rename OemMiscLib class to HisiOemMiscLib >> Hisilicon: add missing include file to Pptt components >> Hisilicon/Hi1620AcpiTables: fix up ASL >> Hisilicon/ProcessorSubClassDxe: drop conflicting PROCESSOR_STATUS_DATA >> type >> Hisilicon: drop unused DS3231RealTimeClockLib instance >> Hisilicon: drop unused VirtualRealTimeClockLib instance >> Hisilicon/DS3231RealTimeClockLib: drop LibRtcVirtualNotifyEvent >> Hisilicon/RX8900RealTimeClockLib: drop LibRtcVirtualNotifyEvent >> AmpereAltraPkg/Ac01PcieLib: fix compilation error >> JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent >> LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent >> Styx/RealTimeClockLib: hide LibRtcVirtualNotifyEvent >> Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent >> NXP/Pcf8563RealTimeClockLib: hide LibRtcVirtualNotifyEvent >> FT2000-4Pkg/RealTimeClockLib: hide LibRtcVirtualNotifyEvent >> Omap35xxPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent >> >=20 > Thanks a lot for cleaning this up! >=20 > For the series, >=20 > Reviewed-by: Ard Biesheuvel >=20 > Pushed as d6e36a151ff8..06f6274d5642 >=20 > edk2-non-osi patch pushed as d6e36a151ff8..06f6274d5642 >=20 Thanks much! :) I'll post a followup for removing the stale MmioRead32() from AmpereAltraPkg/Ac01PcieLib. Cheers Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109610): https://edk2.groups.io/g/devel/message/109610 Mute This Topic: https://groups.io/mt/101914650/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-