From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.11102.1582877563554741485 for ; Fri, 28 Feb 2020 00:12:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YxEhjKLY; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582877562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ZtF5Vblo0GwXmsBh3nc1US4wuB52jO+n8f4Rfk0izM=; b=YxEhjKLYptSAbcjuS4hU+mGNfj6phvOayAsGRLQmA/7TTf9Z4UGcrhzaB93izW7z7ld2hc AxkDMWWMBnoyXfTPz+jmx6SLFPIYSSnaQ11+XPlKxlIjqYVmCkYCdhkwBPU7edATbk3bFU l7iqJtIZXouHD3MTQtIaf0/gkEN5Ut0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-jK0Bp23_O0uYTRPPdtw2rA-1; Fri, 28 Feb 2020 03:12:36 -0500 X-MC-Unique: jK0Bp23_O0uYTRPPdtw2rA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4E66101FC6E; Fri, 28 Feb 2020 08:12:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-243.ams2.redhat.com [10.36.116.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E4AD19925; Fri, 28 Feb 2020 08:12:33 +0000 (UTC) Subject: Re: [PATCH v2 01/13] OvmfPkg/MptScsiDxe: Create empty driver To: Nikita Leshenko , devel@edk2.groups.io Cc: liran.alon@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200226164151.125182-1-nikita.leshchenko@oracle.com> <20200226164151.125182-2-nikita.leshchenko@oracle.com> From: "Laszlo Ersek" Message-ID: <21d9d78c-73a8-4eb0-0126-86aa58a247b9@redhat.com> Date: Fri, 28 Feb 2020 09:12:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200226164151.125182-2-nikita.leshchenko@oracle.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/26/20 17:41, Nikita Leshenko wrote: > In preparation for implementing LSI Fusion MPT SCSI devices, create a > basic scaffolding for a driver. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: Aaron Young > Reviewed-by: Liran Alon > --- > OvmfPkg/MptScsiDxe/MptScsi.c | 30 +++++++++++++++++++++++++++++ > OvmfPkg/MptScsiDxe/MptScsiDxe.inf | 32 +++++++++++++++++++++++++++++++ > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32.fdf | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.fdf | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfPkgX64.fdf | 1 + > 8 files changed, 68 insertions(+) > create mode 100644 OvmfPkg/MptScsiDxe/MptScsi.c > create mode 100644 OvmfPkg/MptScsiDxe/MptScsiDxe.inf With my requests under the blurb addressed: Reviewed-by: Laszlo Ersek