From: "Jessica Clarke" <jrtc27@jrtc27.com>
To: Henz, Patrick <patrick.henz@hpe.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts
Date: Wed, 07 Jun 2023 14:37:58 -0700 [thread overview]
Message-ID: <22021.1686173878687655526@groups.io> (raw)
In-Reply-To: <82fc5045fc091b111edeb45c58b64e6e13599b47.1600889280.git.patrick.henz@hpe.com>
On Wed, Sep 23, 2020 at 08:36 PM, Henz, Patrick wrote:
>
> From: Patrick Henz <patrick.henz@hpe.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948
>
> Timeouts in the XhciDxe driver are taking longer than
> expected due to the timeout loops not accounting for
> code execution time. As en example, 5 second timeouts
> have been observed to take around 36 seconds to complete.
> Use SetTimer and Create/CheckEvent from Boot Services to
> determine when timeout occurred.
This strategy doesn't work during ExitBootServices, as called from
XhcExitBootService via XhcHaltHC. The net result is that, if the XHCI
controller fails to halt upon clearing R/S, EDK2 hangs in an infinite
loop (something I just had the joy of debugging).
Jess
next prev parent reply other threads:[~2023-06-07 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 19:36 [PATCH v3 0/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts Henz, Patrick
2020-09-23 19:36 ` [PATCH v3 1/1] " Henz, Patrick
2020-09-24 1:22 ` [edk2-devel] " Wu, Hao A
2020-09-29 1:31 ` Wu, Hao A
2023-06-07 21:37 ` Jessica Clarke [this message]
2023-06-08 10:32 ` Leif Lindholm
2023-06-08 16:51 ` Henz, Patrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22021.1686173878687655526@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox