From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 0/2] MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it
Date: Mon, 11 Sep 2017 22:30:39 +0200 [thread overview]
Message-ID: <2212c2ae-bc34-5c38-f66c-082026ebb6b8@redhat.com> (raw)
In-Reply-To: <20170904155717.31591-1-lersek@redhat.com>
On 09/04/17 17:57, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: debugprint_iofifo
>
> The first patch (for MdePkg) fixes an assembly language operand ordering
> oversight in the unrolled / SEV implementations of IoWriteFifoXX().
>
> The second patch makes OvmfPkg use IoWriteFifo8() for printing DEBUG
> messages and ASSERT() failures.
>
> Thanks,
> Laszlo
>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Laszlo Ersek (2):
> MdePkg/BaseIoLibIntrinsic: fix SEV (=unrolled) variants of
> IoWriteFifoXX()
> OvmfPkg/PlatformDebugLibIoPort: write messages with IoWriteFifo8()
>
> OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 20 ++++++++------------
> MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 6 +++---
> MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 6 +++---
> 3 files changed, 14 insertions(+), 18 deletions(-)
>
Thanks for the feedback, pushed as aa9aa47e06ac..80886a695377.
Laszlo
prev parent reply other threads:[~2017-09-11 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 15:57 [PATCH 0/2] MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it Laszlo Ersek
2017-09-04 15:57 ` [PATCH 1/2] MdePkg/BaseIoLibIntrinsic: fix SEV (=unrolled) variants of IoWriteFifoXX() Laszlo Ersek
2017-09-05 1:40 ` Gao, Liming
2017-09-05 14:32 ` Brijesh Singh
2017-09-04 15:57 ` [PATCH 2/2] OvmfPkg/PlatformDebugLibIoPort: write messages with IoWriteFifo8() Laszlo Ersek
2017-09-05 14:33 ` Brijesh Singh
2017-09-11 20:30 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2212c2ae-bc34-5c38-f66c-082026ebb6b8@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox