From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 7D1D720958BD5
 for <edk2-devel@lists.01.org>; Mon, 11 Sep 2017 13:27:45 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 1B9DF23C44E;
 Mon, 11 Sep 2017 20:30:41 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1B9DF23C44E
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com;
 spf=fail smtp.mailfrom=lersek@redhat.com
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-112.phx2.redhat.com
 [10.3.116.112])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 26EF91851E;
 Mon, 11 Sep 2017 20:30:39 +0000 (UTC)
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Jordan Justen <jordan.l.justen@intel.com>, Liming Gao <liming.gao@intel.com>
References: <20170904155717.31591-1-lersek@redhat.com>
Message-ID: <2212c2ae-bc34-5c38-f66c-082026ebb6b8@redhat.com>
Date: Mon, 11 Sep 2017 22:30:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170904155717.31591-1-lersek@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Mon, 11 Sep 2017 20:30:41 +0000 (UTC)
Subject: Re: [PATCH 0/2] MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Sep 2017 20:27:45 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 09/04/17 17:57, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: debugprint_iofifo
> 
> The first patch (for MdePkg) fixes an assembly language operand ordering
> oversight in the unrolled / SEV implementations of IoWriteFifoXX().
> 
> The second patch makes OvmfPkg use IoWriteFifo8() for printing DEBUG
> messages and ASSERT() failures.
> 
> Thanks,
> Laszlo
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Laszlo Ersek (2):
>   MdePkg/BaseIoLibIntrinsic: fix SEV (=unrolled) variants of
>     IoWriteFifoXX()
>   OvmfPkg/PlatformDebugLibIoPort: write messages with IoWriteFifo8()
> 
>  OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c     | 20 ++++++++------------
>  MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm |  6 +++---
>  MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm  |  6 +++---
>  3 files changed, 14 insertions(+), 18 deletions(-)
> 

Thanks for the feedback, pushed as aa9aa47e06ac..80886a695377.

Laszlo