From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.25707.1574351709896736294 for ; Thu, 21 Nov 2019 07:55:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NH+QxXxg; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574351709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cr/wTB3xAJbwXLM29Yu2xy5H/UJsDeyBW4IWxnZ9s40=; b=NH+QxXxgBkRbZMGGZzMRzUt3u+OAW8hIA5fYNKioXOMRHMDOX4LN5qEDOSvhJpiVXzH0Qu yqklDHPsazSgag3J38s0VJQO7qBTzRmN6TVdH0BdlH+L5Wp2f0UcvmFrEGanCh+ma1A5cY V5FLZm34MdZuLtThdc7FncP6TbsdN8M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-qVD3xS6fPPKyrjAj3BIKZw-1; Thu, 21 Nov 2019 10:55:07 -0500 Received: by mail-wm1-f69.google.com with SMTP id y133so1727566wmd.8 for ; Thu, 21 Nov 2019 07:55:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UlL4RvhZONMbDe+l3vXltpPCuNiNiv/i56CIZq9dqHM=; b=J7I5PlJ8+LMT4uCRyjink8MQcF5Ywy0lRUPf2C4MAUuRu/2/8T9CZ/o5DZoz0pFSjZ UbWRHiuvgqF/QYWA6WZMp4Ir8pXY+YItYAsyltP7HRj+PQdoTA6bBS/UA3JjklpNY3/Y oOE1Z7samSjvmNFLOL7xP9QIymcJc+lSdwXt+fauT1SuiSFcfiACCGkwNVgcgrylXYG7 SWZKUdgKApTcaoonkbc5+RMsi8HemPgUNsMHk0I9hwiTbiiVJfFUP0nZqjh0DOtf96Qp B4SpVV0wnb1C2Voqt8zEyB+9dpWmCA6J1iR6keEWOj6A/mzmQxobk0mUr1aDG91AkNhq WQpg== X-Gm-Message-State: APjAAAWzkVAu8R/mwDS+iaO69uVqWzsfzkgBcmwnhY0miHIsmfBb5v+x zwu9Z/sL+kQCVk3Ppcg8ZJEwNLW4dzifnUuQoCouXXc26Mne/bXVY142jKtADdX401jYC+JL9Se 9A5XvX7Wi413ccQ== X-Received: by 2002:a05:600c:3cd:: with SMTP id z13mr10815642wmd.105.1574351704886; Thu, 21 Nov 2019 07:55:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwNLIJytfkoGTUmTqIXBdrw7U5oUuabCZZon5dP4Y7G6myDjIeMQtOlWDO+B4MA2ExHOImAlQ== X-Received: by 2002:a05:600c:3cd:: with SMTP id z13mr10815622wmd.105.1574351704687; Thu, 21 Nov 2019 07:55:04 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id d20sm3950565wra.4.2019.11.21.07.55.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:55:04 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v1 10/19] DynamicTablesPkg: Serial debug port initialisation To: Leif Lindholm Cc: devel@edk2.groups.io, sami.mujawar@arm.com, Alexei.Fedorov@arm.com, Matteo.Carlini@arm.com, nd@arm.com References: <20190823105539.13260-1-sami.mujawar@arm.com> <20190823105539.13260-11-sami.mujawar@arm.com> <20191121152320.GH7359@bivouac.eciton.net> <90d963b6-4422-cdac-ed20-61f0e2329fe3@redhat.com> <20191121154856.GI7359@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <221d4247-bb83-d247-610e-a32f04e8d49a@redhat.com> Date: Thu, 21 Nov 2019 16:55:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121154856.GI7359@bivouac.eciton.net> X-MC-Unique: qVD3xS6fPPKyrjAj3BIKZw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/21/19 4:48 PM, Leif Lindholm wrote: > On Thu, Nov 21, 2019 at 16:29:16 +0100, Philippe Mathieu-Daud=C3=A9 wrote= : >> On 11/21/19 4:23 PM, Leif Lindholm wrote: >>> On Thu, Nov 21, 2019 at 16:20:31 +0100, Philippe Mathieu-Daud=C3=A9 wro= te: >>>> On 8/23/19 12:55 PM, Sami Mujawar wrote: >>>>> The ARM DCC serial port subtype is an option that is >>>>> supported by the DBG2 generator. However, the serial >>>>> port initialisation should only be done for PL011/SBSA >>>>> compatible UARTs. >>>>> >>>>> Add check to conditionally initialise the serial port. >>>>> >>>>> Signed-off-by: Sami Mujawar >>>>> --- >>>>> DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c = | 27 ++++++++++++-------- >>>>> 1 file changed, 17 insertions(+), 10 deletions(-) >>>>> >>>>> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Gen= erator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c >>>>> index 346ab5b22f5402bf87c385558f68f080d1b454ed..51c843d25f75388104694= 855ce133b3d61860196 100644 >>>>> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.= c >>>>> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.= c >>>>> @@ -175,7 +175,7 @@ GET_OBJECT_LIST ( >>>>> CM_ARM_SERIAL_PORT_INFO >>>>> ); >>>>> -/** Initialize the PL011 UART with the parameters obtained from >>>>> +/** Initialize the PL011/SBSA UART with the parameters obtained from >>>>> the Configuration Manager. >>>> >>>> Isn't the SBSA UART a PL011? >>> >>> No. It's a compatible subset. >>> So a PL011 can be used as an SBSA UART. >> >> OK thanks. >> >> Can you update the comment? Maybe: >> >> "Initialize the PL011 compatible UART with the parameters ..." >=20 > The original is correct, the suggested alternative is not (an SBSA > UART is a subset, so not fully compatible). OK, thanks for clarifying. >=20 > If the comment was to change, I would suggest that dropping the model > name completely and simply refer to it as "the UART" would be > preferable. >=20 > / > Leif >=20 >> Regardless: >> Reviewed-by: Philippe Mathieu-Daude >> >>> >>> / >>> Leif >=20