public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Stefan Berger" <stefanb@linux.ibm.com>
To: Gerd Hoffmann <kraxel@redhat.com>, devel@edk2.groups.io
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Min Xu" <min.m.xu@intel.com>,
	"Brijesh Singh" <brijesh.singh@amd.com>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"James Bottomley" <jejb@linux.ibm.com>,
	"Erdem Aktas" <erdemaktas@google.com>,
	"Tom Lendacky" <thomas.lendacky@amd.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>
Subject: Re: [PATCH v2 5/5] OvmfPkg: add TPM 1.2 config menu
Date: Mon, 25 Oct 2021 09:12:48 -0400	[thread overview]
Message-ID: <2222b9f9-f1be-99ad-7c2b-bc34bb131bb0@linux.ibm.com> (raw)
In-Reply-To: <20211025121512.120926-6-kraxel@redhat.com>


On 10/25/21 8:15 AM, Gerd Hoffmann wrote:
> When building OVMF with TPM 1.2 support enabled
> do also include the configuration menu.
>
> Suggested-by: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

The menu is there but it doesn't react to the selections, which I hadn't 
tested before. Maybe drop this patch in v3 and when I have time for 
looking into this I may post it again with fixes to actually make the 
menu items work.


     Stefan


> ---
>   OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 +
>   OvmfPkg/OvmfTpmDxe.fdf.inc           | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc b/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc
> index 75ae09571e8c..cdcae42ad1dc 100644
> --- a/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc
> +++ b/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc
> @@ -20,6 +20,7 @@
>       <LibraryClasses>
>         Tpm12DeviceLib|SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12DeviceLibDTpm.inf
>     }
> +  SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDxe.inf
>   !endif
>     SecurityPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf {
>       <LibraryClasses>
> diff --git a/OvmfPkg/OvmfTpmDxe.fdf.inc b/OvmfPkg/OvmfTpmDxe.fdf.inc
> index 7fc2bf8590a4..5907d8a8f1f3 100644
> --- a/OvmfPkg/OvmfTpmDxe.fdf.inc
> +++ b/OvmfPkg/OvmfTpmDxe.fdf.inc
> @@ -5,6 +5,7 @@
>   !if $(TPM2_ENABLE) == TRUE
>   !if $(TPM1_ENABLE) == TRUE
>   INF  SecurityPkg/Tcg/TcgDxe/TcgDxe.inf
> +INF  SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDxe.inf
>   !endif
>   INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
>   INF  SecurityPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf

      reply	other threads:[~2021-10-25 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 12:15 [PATCH v2 0/5] OvmfPkg: rework TPM configuration Gerd Hoffmann
2021-10-25 12:15 ` [PATCH v2 1/5] OvmfPkg: move tcg configuration to dsc and fdf include files Gerd Hoffmann
2021-10-25 13:21   ` Stefan Berger
2021-10-25 12:15 ` [PATCH v2 2/5] OvmfPkg: drop TPM_CONFIG_ENABLE Gerd Hoffmann
2021-10-25 12:40   ` Stefan Berger
2021-10-25 12:15 ` [PATCH v2 3/5] OvmfPkg: create Tcg12ConfigPei.inf Gerd Hoffmann
2021-10-25 12:54   ` Stefan Berger
2021-10-25 12:15 ` [PATCH v2 4/5] OvmfPkg: rework TPM configuration Gerd Hoffmann
2021-10-25 13:06   ` Stefan Berger
2021-10-25 12:15 ` [PATCH v2 5/5] OvmfPkg: add TPM 1.2 config menu Gerd Hoffmann
2021-10-25 13:12   ` Stefan Berger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2222b9f9-f1be-99ad-7c2b-bc34bb131bb0@linux.ibm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox