From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web10.31765.1635167575737593228 for ; Mon, 25 Oct 2021 06:12:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=KYlVia2o; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19PCMAX7013198; Mon, 25 Oct 2021 13:12:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=4DdTvuOciDoRbjHqLKrrRZ3/Buy5ghbHuJYHqWDXGjk=; b=KYlVia2oo9ljauWLcXMFna6i2cqtKiMtKGKo3gSL+1dyW8lVTjxFG5Z8Sf8mTQuDLpHx M/ewsv4bmI4wEHV0IbsSIL1eYDO5pS9PvJsRBZ1ubL9zgpuNXNSEdLhy5noTXMHCOADP 6fnStfZNDq20IN4jlR3sPfadxF27HtqTTihBhOHAgyTsnT0GpxmeydBKRMhhdbEeMusj uRAWENoZTP7CaGhqAS4SGHlRxfzCz85TRKq4IMR1x38B02YxpzTuUIkOAyJ53eozs1T/ urRshsEEg64Qad+LK59Ag224qL5x+4mNqX6aBbZMo7u4tTd9SCQTQUHHQGfefg+ZJQTj Hw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bwt23nbb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Oct 2021 13:12:52 +0000 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19PCMAAb013247; Mon, 25 Oct 2021 13:12:51 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bwt23nbaq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Oct 2021 13:12:51 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19PD7RQb006700; Mon, 25 Oct 2021 13:12:51 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02wdc.us.ibm.com with ESMTP id 3bva1amvre-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Oct 2021 13:12:51 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19PDCoVC52298150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Oct 2021 13:12:50 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F254E7807E; Mon, 25 Oct 2021 13:12:49 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E255678060; Mon, 25 Oct 2021 13:12:48 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 25 Oct 2021 13:12:48 +0000 (GMT) Subject: Re: [PATCH v2 5/5] OvmfPkg: add TPM 1.2 config menu To: Gerd Hoffmann , devel@edk2.groups.io Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Jordan Justen , Min Xu , Brijesh Singh , Jiewen Yao , James Bottomley , Erdem Aktas , Tom Lendacky , Ard Biesheuvel References: <20211025121512.120926-1-kraxel@redhat.com> <20211025121512.120926-6-kraxel@redhat.com> From: "Stefan Berger" Message-ID: <2222b9f9-f1be-99ad-7c2b-bc34bb131bb0@linux.ibm.com> Date: Mon, 25 Oct 2021 09:12:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211025121512.120926-6-kraxel@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ViR5MTrlc82cxvGAl38-0JasWqHxn6LK X-Proofpoint-ORIG-GUID: G4KzxtaRu0mJCkItPdVuMoXw9cYHLHgj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-25_05,2021-10-25_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 mlxscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110250081 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-001b2d01.pphosted.com id 19PCMAX7013198 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/25/21 8:15 AM, Gerd Hoffmann wrote: > When building OVMF with TPM 1.2 support enabled > do also include the configuration menu. > > Suggested-by: Stefan Berger > Signed-off-by: Gerd Hoffmann The menu is there but it doesn't react to the selections, which I hadn't=20 tested before. Maybe drop this patch in v3 and when I have time for=20 looking into this I may post it again with fixes to actually make the=20 menu items work. =C2=A0=C2=A0=C2=A0 Stefan > --- > OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 + > OvmfPkg/OvmfTpmDxe.fdf.inc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc b/OvmfPkg/OvmfTpmComp= onentsDxe.dsc.inc > index 75ae09571e8c..cdcae42ad1dc 100644 > --- a/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc > +++ b/OvmfPkg/OvmfTpmComponentsDxe.dsc.inc > @@ -20,6 +20,7 @@ > > Tpm12DeviceLib|SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12Devi= ceLibDTpm.inf > } > + SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDxe.inf > !endif > SecurityPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf { > > diff --git a/OvmfPkg/OvmfTpmDxe.fdf.inc b/OvmfPkg/OvmfTpmDxe.fdf.inc > index 7fc2bf8590a4..5907d8a8f1f3 100644 > --- a/OvmfPkg/OvmfTpmDxe.fdf.inc > +++ b/OvmfPkg/OvmfTpmDxe.fdf.inc > @@ -5,6 +5,7 @@ > !if $(TPM2_ENABLE) =3D=3D TRUE > !if $(TPM1_ENABLE) =3D=3D TRUE > INF SecurityPkg/Tcg/TcgDxe/TcgDxe.inf > +INF SecurityPkg/Tcg/TcgConfigDxe/TcgConfigDxe.inf > !endif > INF SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > INF SecurityPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf