* [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
@ 2019-08-08 8:09 Zhang, Shenglei
2019-08-08 9:55 ` [edk2-devel] " Leif Lindholm
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Shenglei @ 2019-08-08 8:09 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Ard Biesheuvel, Leif Lindholm, Eugene Cohen
Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
in tools_def.template. These tool chains are for ARM and AARCH64 only.
There is no change recently and they are not used.
https://bugzilla.tianocore.org/show_bug.cgi?id=1750
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Eugene Cohen <eugene@hp.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
BaseTools/Conf/tools_def.template | 240 ------------------------------
1 file changed, 240 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index 26a2cf604f74..a65cd276bc6e 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -236,12 +236,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
# Required to build platforms or ACPI tables:
# Intel(r) ACPI Compiler from
# https://acpica.org/downloads
-# CLANG35 -Linux,Windows- Requires:
-# Clang v3.5 or later, and GNU binutils targeting aarch64-linux-gnu or arm-linux-gnueabi
-# Optional:
-# Required to build platforms or ACPI tables:
-# Intel(r) ACPI Compiler from
-# https://acpica.org/downloads
# CLANG38 -Linux- Requires:
# Clang v3.8, LLVMgold plugin and GNU binutils 2.26 targeting x86_64-linux-gnu, aarch64-linux-gnu or arm-linux-gnueabi
# Clang v3.9 or later, LLVMgold plugin and GNU binutils 2.28 targeting x86_64-linux-gnu, aarch64-linux-gnu or arm-linux-gnueabi
@@ -284,20 +278,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
# Required to build platforms or ACPI tables:
# Intel(r) ACPI Compiler (iasl.exe) from
# https://acpica.org/downloads
-# RVCT -win- Requires:
-# ARM C/C++ Compiler, 5.00
-# Optional:
-# Required to build EBC drivers:
-# Intel(r) Compiler for Efi Byte Code (Intel(r) EBC Compiler)
-# Required to build platforms or ACPI tables:
-# Microsoft ASL ACPI Compiler (asl.exe) v4.0.0 from
-# http://download.microsoft.com/download/2/c/1/2c16c7e0-96c1-40f5-81fc-3e4bf7b65496/microsoft_asl_compiler-v4-0-0.msi
-# RVCTLINUX -unix- Requires:
-# ARM C/C++ Compiler, 5.00
-# Optional:
-# Required to build platforms or ACPI tables:
-# Intel(r) ACPI Compiler from
-# https://acpica.org/downloads
# * Commented out - All versions of VS2005 use the same standard install directory
#
####################################################################################
@@ -308,7 +288,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
# MSFT - Microsoft
# GCC - GNU GCC
# INTEL - INTEL
-# RVCT - ARM RealView Toolchain
####################################################################################
####################################################################################
#
@@ -2247,87 +2226,6 @@ RELEASE_GCC5_AARCH64_DLINK_XIPFLAGS = -z common-page-size=0x20
NOOPT_GCC5_AARCH64_DLINK_FLAGS = DEF(GCC5_AARCH64_DLINK_FLAGS) -O0
NOOPT_GCC5_AARCH64_DLINK_XIPFLAGS = -z common-page-size=0x20 -O0
-####################################################################################
-#
-# CLANG35 - This configuration is used to compile under Linux to produce
-# PE/COFF binaries using the clang compiler and assembler (v3.5 and up)
-# and GNU linker
-#
-####################################################################################
-*_CLANG35_*_*_FAMILY = GCC
-
-*_CLANG35_*_MAKE_PATH = make
-*_CLANG35_*_*_DLL = ENV(CLANG35_DLL)
-*_CLANG35_*_ASL_PATH = DEF(UNIX_IASL_BIN)
-
-*_CLANG35_*_PP_FLAGS = DEF(GCC_PP_FLAGS)
-*_CLANG35_*_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
-*_CLANG35_*_APP_FLAGS =
-*_CLANG35_*_ASL_FLAGS = DEF(IASL_FLAGS)
-*_CLANG35_*_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS)
-*_CLANG35_*_DTCPP_FLAGS = DEF(GCC_DTCPP_FLAGS)
-
-*_CLANG35_*_CC_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_ASM_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_PP_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_VFRPP_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_ASLCC_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_ASLPP_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_DLINK_PATH = ENV(CLANG35_BIN)clang
-*_CLANG35_*_ASLDLINK_PATH = ENV(CLANG35_BIN)clang
-
-DEFINE CLANG35_ARM_TARGET = -target arm-linux-gnueabi
-DEFINE CLANG35_AARCH64_TARGET = -target aarch64-linux-gnu
-
-DEFINE CLANG35_WARNING_OVERRIDES = -Wno-parentheses-equality -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-empty-body -Wno-unknown-warning-option
-DEFINE CLANG35_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) DEF(CLANG35_ARM_TARGET) DEF(CLANG35_WARNING_OVERRIDES)
-DEFINE CLANG35_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64_TARGET) -mcmodel=small DEF(CLANG35_WARNING_OVERRIDES)
-
-##################
-# CLANG35 ARM definitions
-##################
-*_CLANG35_ARM_SLINK_PATH = ENV(CLANG35_ARM_PREFIX)ar
-*_CLANG35_ARM_RC_PATH = ENV(CLANG35_ARM_PREFIX)objcopy
-
-*_CLANG35_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
-*_CLANG35_ARM_ASLDLINK_FLAGS = DEF(CLANG35_ARM_TARGET) DEF(GCC_ARM_ASLDLINK_FLAGS)
-*_CLANG35_ARM_ASM_FLAGS = DEF(GCC_ASM_FLAGS) DEF(CLANG35_ARM_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) -Qunused-arguments
-*_CLANG35_ARM_DLINK_FLAGS = DEF(CLANG35_ARM_TARGET) DEF(GCC_ARM_DLINK_FLAGS)
-*_CLANG35_ARM_DLINK2_FLAGS = DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,--defsym=PECOFF_HEADER_SIZE=0x220
-*_CLANG35_ARM_PLATFORM_FLAGS = -march=armv7-a -mkernel -Qunused-arguments
-*_CLANG35_ARM_PP_FLAGS = DEF(GCC_PP_FLAGS) DEF(CLANG35_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
-*_CLANG35_ARM_RC_FLAGS = DEF(GCC_ARM_RC_FLAGS)
-*_CLANG35_ARM_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) DEF(CLANG35_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
-*_CLANG35_ARM_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANG35_ARM_TARGET)
-*_CLANG35_ARM_CC_XIPFLAGS = DEF(GCC_ARM_CC_XIPFLAGS)
-
- DEBUG_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O1
-RELEASE_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz
- NOOPT_CLANG35_ARM_CC_FLAGS = DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0
-
-##################
-# CLANG35 AARCH64 definitions
-##################
-*_CLANG35_AARCH64_SLINK_PATH = ENV(CLANG35_AARCH64_PREFIX)ar
-*_CLANG35_AARCH64_RC_PATH = ENV(CLANG35_AARCH64_PREFIX)objcopy
-
-*_CLANG35_AARCH64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
-*_CLANG35_AARCH64_ASLDLINK_FLAGS = DEF(CLANG35_AARCH64_TARGET) DEF(GCC_AARCH64_ASLDLINK_FLAGS)
-*_CLANG35_AARCH64_ASM_FLAGS = DEF(GCC_ASM_FLAGS) DEF(CLANG35_AARCH64_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) -Qunused-arguments
-*_CLANG35_AARCH64_DLINK_FLAGS = DEF(CLANG35_AARCH64_TARGET) DEF(GCC_AARCH64_DLINK_FLAGS) -z common-page-size=0x1000
-*_CLANG35_AARCH64_DLINK_XIPFLAGS = -z common-page-size=0x20
-*_CLANG35_AARCH64_DLINK2_FLAGS = DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,--defsym=PECOFF_HEADER_SIZE=0x228
-*_CLANG35_AARCH64_PLATFORM_FLAGS =
-*_CLANG35_AARCH64_PP_FLAGS = DEF(GCC_PP_FLAGS) DEF(CLANG35_AARCH64_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
-*_CLANG35_AARCH64_RC_FLAGS = DEF(GCC_AARCH64_RC_FLAGS)
-*_CLANG35_AARCH64_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) DEF(CLANG35_AARCH64_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
-*_CLANG35_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) DEF(CLANG35_AARCH64_TARGET)
-*_CLANG35_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS)
-
- DEBUG_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O1
-RELEASE_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz
- NOOPT_CLANG35_AARCH64_CC_FLAGS = DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0
-
####################################################################################
#
# Clang 3.8 - This configuration is used to compile under Linux to produce
@@ -2597,144 +2495,6 @@ RELEASE_XCODE5_X64_ASM_FLAGS = -arch x86_64
NOOPT_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -g -O0 -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-float -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare -Wno-varargs -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
RELEASE_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -Os -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-float -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare -Wno-varargs -Wno-unused-const-variable -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
-####################################################################################
-#
-# RVCT Common
-#
-####################################################################################
-
-DEFINE RVCT_ALL_ASM_FLAGS = --diag_suppress=1786 --diag_error=warning --apcs /interwork
-DEFINE RVCT_ALL_CC_FLAGS = --c90 --no_autoinline --asm --gnu --apcs /interwork --signed_chars --no_unaligned_access --split_sections --enum_is_int --preinclude AutoGen.h --diag_suppress=186,188,1,111,68 --diag_warning 167 --diag_error=warning --diag_style=ide --protect_stack
-DEFINE RVCT_ALL_DLINK_FLAGS = --no_scanlib --no_exceptions --datacompressor off --strict --symbols --diag_style=ide --no_legacyalign --scatter $(EDK_TOOLS_PATH)/Scripts/Rvct-Align32.sct
-
-####################################################################################
-#
-# ARM RealView Tools - Windows
-#
-####################################################################################
-# RVCT - Tools from ARM
-
-*_RVCT_*_*_FAMILY = RVCT
-
-#
-# Use default values, or override in DSC file
-#
-*_RVCT_ARM_ARCHCC_FLAGS = --thumb --fpu=softvfp
-*_RVCT_ARM_ARCHASM_FLAGS =
-*_RVCT_ARM_ARCHDLINK_FLAGS =
-*_RVCT_ARM_PLATFORM_FLAGS = --cpu 7-A
-
- DEBUG_RVCT_ARM_DLINK_FLAGS = $(ARCHDLINK_FLAGS) DEF(RVCT_ALL_DLINK_FLAGS) --entry $(IMAGE_ENTRY_POINT) --map --list $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-RELEASE_RVCT_ARM_DLINK_FLAGS = $(ARCHDLINK_FLAGS) DEF(RVCT_ALL_DLINK_FLAGS) --entry $(IMAGE_ENTRY_POINT) --map --list $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-
-
-*_RVCT_ARM_ASM_FLAGS = $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(RVCT_ALL_ASM_FLAGS)
-*_RVCT_ARM_PP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E --preinclude AutoGen.h
-*_RVCT_ARM_VFRPP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E -DVFRCOMPILE --preinclude $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
-*_RVCT_ARM_MAKE_PATH = nmake /NOLOGO
-*_RVCT_ARM_SLINK_FLAGS = --partial -o
- DEBUG_RVCT_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(RVCT_ALL_CC_FLAGS) -O1 -g
-RELEASE_RVCT_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) --diag_suppress=550 DEF(RVCT_ALL_CC_FLAGS) -O2
-
-##################
-# ARM definitions
-##################
-*_RVCT_ARM_CC_PATH = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCT_ARM_SLINK_PATH = ENV(RVCT_TOOLS_PATH)armlink
-*_RVCT_ARM_DLINK_PATH = ENV(RVCT_TOOLS_PATH)armlink
-*_RVCT_ARM_ASM_PATH = ENV(RVCT_TOOLS_PATH)armasm
-*_RVCT_ARM_PP_PATH = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCT_ARM_VFRPP_PATH = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCT_ARM_FROMELF_PATH = ENV(RVCT_TOOLS_PATH)fromelf
-
-####################################################################################
-#
-# ARM RealView Tools - Linux
-#
-####################################################################################
-# RVCTLINUX - Tools from ARM in a Cygwin environment
-*_RVCTLINUX_*_*_FAMILY = RVCT
-*_RVCTLINUX_*_*_BUILDRULEFAMILY = RVCTLINUX
-
-*_RVCTLINUX_*_MAKE_PATH = make
-
-#
-# Use default values, or override in DSC file
-#
-*_RVCTLINUX_ARM_ARCHCC_FLAGS = --thumb --fpu=softvfp
-*_RVCTLINUX_ARM_ARCHASM_FLAGS =
-*_RVCTLINUX_ARM_ARCHDLINK_FLAGS =
-*_RVCTLINUX_ARM_PLATFORM_FLAGS = --cpu 7-A
-
-DEBUG_RVCTLINUX_ARM_DLINK_FLAGS = $(ARCHDLINK_FLAGS) DEF(RVCT_ALL_DLINK_FLAGS) --entry $(IMAGE_ENTRY_POINT) --map --list $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-RELEASE_RVCTLINUX_ARM_DLINK_FLAGS = $(ARCHDLINK_FLAGS) DEF(RVCT_ALL_DLINK_FLAGS) --entry $(IMAGE_ENTRY_POINT) --map --list $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-
-*_RVCTLINUX_ARM_ASM_FLAGS = $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(RVCT_ALL_ASM_FLAGS)
-*_RVCTLINUX_ARM_PP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E
-*_RVCTLINUX_ARM_VFRPP_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E -DVFRCOMPILE --preinclude $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
-*_RVCTLINUX_ARM_SLINK_FLAGS = --partial -o
- DEBUG_RVCTLINUX_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(RVCT_ALL_CC_FLAGS) -O1 -g
-RELEASE_RVCTLINUX_ARM_CC_FLAGS = $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) --diag_suppress=550 DEF(RVCT_ALL_CC_FLAGS) -O2
-
-##################
-# ARM definitions
-##################
-*_RVCTLINUX_ARM_CC_PATH = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCTLINUX_ARM_SLINK_PATH = ENV(RVCT_TOOLS_PATH)armlink
-*_RVCTLINUX_ARM_DLINK_PATH = ENV(RVCT_TOOLS_PATH)armlink
-*_RVCTLINUX_ARM_ASM_PATH = ENV(RVCT_TOOLS_PATH)armasm
-*_RVCTLINUX_ARM_PP_PATH = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCTLINUX_ARM_VFRPP_PATH = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCTLINUX_ARM_FROMELF_PATH = ENV(RVCT_TOOLS_PATH)fromelf
-
-####################################################################################
-#
-# ARM RealView Tools - Cygwin
-#
-####################################################################################
-# ARMCYGWIN - Tools from ARM in a Cygwin environment
-
-*_RVCTCYGWIN_*_*_FAMILY = RVCT
-*_RVCTCYGWIN_*_*_BUILDRULEFAMILY = RVCTCYGWIN
-
-*_RVCTCYGWIN_ARM_CCPATH_FLAG = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCTCYGWIN_ARM_SLINKPATH_FLAG = ENV(RVCT_TOOLS_PATH)armlink
-*_RVCTCYGWIN_ARM_DLINKPATH_FLAG = ENV(RVCT_TOOLS_PATH)armlink
-*_RVCTCYGWIN_ARM_ASMPATH_FLAG = ENV(RVCT_TOOLS_PATH)armasm
-*_RVCTCYGWIN_ARM_PPPATH_FLAG = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCTCYGWIN_ARM_VFRPPPATH_FLAG = ENV(RVCT_TOOLS_PATH)armcc
-*_RVCTCYGWIN_ARM_FROMELFPATH_FLAG = ENV(RVCT_TOOLS_PATH)fromelf
-
-#
-# Use default values, or override in DSC file
-#
-*_RVCTCYGWIN_ARM_ARCHCC_FLAGS = --thumb --fpu=softvfp
-*_RVCTCYGWIN_ARM_ARCHASM_FLAGS =
-*_RVCTCYGWIN_ARM_ARCHDLINK_FLAGS =
-*_RVCTCYGWIN_ARM_PLATFORM_FLAGS = --cpu 7-A
-
- DEBUG_RVCTCYGWIN_ARM_DLINK_FLAGS = "$(DLINKPATH_FLAG)" $(ARCHDLINK_FLAGS) DEF(RVCT_ALL_DLINK_FLAGS) --entry $(IMAGE_ENTRY_POINT) --map --list `cygpath -m $(DEST_DIR_DEBUG)/$(BASE_NAME).map`
-RELEASE_RVCTCYGWIN_ARM_DLINK_FLAGS = "$(DLINKPATH_FLAG)" $(ARCHDLINK_FLAGS) DEF(RVCT_ALL_DLINK_FLAGS) --entry $(IMAGE_ENTRY_POINT) --map --list `cygpath -m $(DEST_DIR_DEBUG)/$(BASE_NAME).map`
-
-*_RVCTCYGWIN_ARM_ASM_FLAGS = "$(ASMPATH_FLAG)" $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) DEF(RVCT_ALL_ASM_FLAGS)
-*_RVCTCYGWIN_ARM_PP_FLAGS = "$(CCPATH_FLAG)" $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E
-*_RVCTCYGWIN_ARM_VFRPP_FLAGS = "$(CCPATH_FLAG)" $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -E -DVFRCOMPILE --preinclude `cygpath -m $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h`
-*_RVCTCYGWIN_ARM_MAKE_PATH = make
-*_RVCTCYGWIN_ARM_SLINK_FLAGS = "$(SLINKPATH_FLAG)" --partial -o
- DEBUG_RVCTCYGWIN_ARM_CC_FLAGS = "$(CCPATH_FLAG)" $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) DEF(RVCT_ALL_CC_FLAGS) -O1 -g
-RELEASE_RVCTCYGWIN_ARM_CC_FLAGS = "$(CCPATH_FLAG)" $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) --diag_suppress=550 DEF(RVCT_ALL_CC_FLAGS) -O2
-
-##################
-# ARM definitions
-##################
-*_RVCTCYGWIN_ARM_CC_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-*_RVCTCYGWIN_ARM_SLINK_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-*_RVCTCYGWIN_ARM_DLINK_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-*_RVCTCYGWIN_ARM_ASM_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-*_RVCTCYGWIN_ARM_PP_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-*_RVCTCYGWIN_ARM_VFRPP_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-*_RVCTCYGWIN_ARM_FROMELF_PATH = ENV(WORKSPACE)/BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py
-
#################
# ASM 16 linker definitions
#################
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
2019-08-08 8:09 [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template Zhang, Shenglei
@ 2019-08-08 9:55 ` Leif Lindholm
2019-08-08 10:51 ` Liming Gao
2019-08-08 20:46 ` Laszlo Ersek
0 siblings, 2 replies; 5+ messages in thread
From: Leif Lindholm @ 2019-08-08 9:55 UTC (permalink / raw)
To: devel, shenglei.zhang; +Cc: Bob Feng, Liming Gao, Ard Biesheuvel, Eugene Cohen
Hi Shenglei,
On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
> in tools_def.template. These tool chains are for ARM and AARCH64 only.
> There is no change recently and they are not used.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
This still does not address my comment in the BZ that deleting all
RVCT profiles before full VS support is enabled for (32-bit) ARM, we
orphan an awful lot of .asm files.
This may not have much of a practical effect, since I doubt anyone is
using these toolchains today - but it does prevent someone from
actively going through and testing future updates (where before, they
may just have neglected to do so).
This point needs discussing rather than ignoring, and I think we're
getting too close to the freeze to consider the patch to go in as is
at this point.
Whenever this patch does go in should be in the week after a stable
tag is made, to give plenty of time for anyone affected to shout
before the next stable tag is made.
After the 2019.08 stable tag has been made, I am happy for a patch
going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.
The deletion of the final RVCT profile needs further discussion.
Best Regards,
Leif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
2019-08-08 9:55 ` [edk2-devel] " Leif Lindholm
@ 2019-08-08 10:51 ` Liming Gao
2019-08-08 11:30 ` Leif Lindholm
2019-08-08 20:46 ` Laszlo Ersek
1 sibling, 1 reply; 5+ messages in thread
From: Liming Gao @ 2019-08-08 10:51 UTC (permalink / raw)
To: Leif Lindholm, devel@edk2.groups.io, Zhang, Shenglei
Cc: Feng, Bob C, Ard Biesheuvel, Eugene Cohen
Leif:
>-----Original Message-----
>From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>Sent: Thursday, August 08, 2019 5:55 PM
>To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
>Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
>Eugene Cohen <eugene@hp.com>
>Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in
>tools_def.template
>
>Hi Shenglei,
>
>On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
>> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
>> in tools_def.template. These tool chains are for ARM and AARCH64 only.
>> There is no change recently and they are not used.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
>
>This still does not address my comment in the BZ that deleting all
>RVCT profiles before full VS support is enabled for (32-bit) ARM, we
>orphan an awful lot of .asm files.
>
How about submit another BZ for VS tool chain ARM fully support?
When there is real request, this support can be added in future.
>This may not have much of a practical effect, since I doubt anyone is
>using these toolchains today - but it does prevent someone from
>actively going through and testing future updates (where before, they
>may just have neglected to do so).
>
>This point needs discussing rather than ignoring, and I think we're
>getting too close to the freeze to consider the patch to go in as is
>at this point.
>
Agree for more discussion.
>Whenever this patch does go in should be in the week after a stable
>tag is made, to give plenty of time for anyone affected to shout
>before the next stable tag is made.
>
>After the 2019.08 stable tag has been made, I am happy for a patch
>going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.
>
If no one maintain or use it, this tool chain may not work now.
If so, do we still need to keep it?
Thanks
Liming
>The deletion of the final RVCT profile needs further discussion.
>
>Best Regards,
>
>Leif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
2019-08-08 10:51 ` Liming Gao
@ 2019-08-08 11:30 ` Leif Lindholm
0 siblings, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2019-08-08 11:30 UTC (permalink / raw)
To: Gao, Liming
Cc: devel@edk2.groups.io, Zhang, Shenglei, Feng, Bob C,
Ard Biesheuvel, Eugene Cohen
On Thu, Aug 08, 2019 at 10:51:54AM +0000, Gao, Liming wrote:
> Leif:
>
> >-----Original Message-----
> >From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> >Sent: Thursday, August 08, 2019 5:55 PM
> >To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> >Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> ><liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>;
> >Eugene Cohen <eugene@hp.com>
> >Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in
> >tools_def.template
> >
> >Hi Shenglei,
> >
> >On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
> >> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
> >> in tools_def.template. These tool chains are for ARM and AARCH64 only.
> >> There is no change recently and they are not used.
> >> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
> >
> >This still does not address my comment in the BZ that deleting all
> >RVCT profiles before full VS support is enabled for (32-bit) ARM, we
> >orphan an awful lot of .asm files.
> >
>
> How about submit another BZ for VS tool chain ARM fully support?
> When there is real request, this support can be added in future.
Good point. I have raised
https://bugzilla.tianocore.org/show_bug.cgi?id=2065
and assigned it to myself.
> >This may not have much of a practical effect, since I doubt anyone is
> >using these toolchains today - but it does prevent someone from
> >actively going through and testing future updates (where before, they
> >may just have neglected to do so).
> >
> >This point needs discussing rather than ignoring, and I think we're
> >getting too close to the freeze to consider the patch to go in as is
> >at this point.
> >
>
> Agree for more discussion.
>
> >Whenever this patch does go in should be in the week after a stable
> >tag is made, to give plenty of time for anyone affected to shout
> >before the next stable tag is made.
> >
> >After the 2019.08 stable tag has been made, I am happy for a patch
> >going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.
>
> If no one maintain or use it, this tool chain may not work now.
> If so, do we still need to keep it?
So there are two questions here, really:
The first - "why can't we delete all of these now?", I think I have
already explained above. (I am not suggesting you did not understand,
but I want to clarify that we also need agreement on the timing of
this patch in general.)
For the second: the Visual Studio assembler (for ARM/AArch64) shares
the .asm syntax (and source file name) with the RVCT assembler.
If we delete the whole RVCT family of profiles, we are left with a
bunch of .asm files that are defined to be assembled by a non-existing
toolchain family. Whilst still being of the name and syntax that we
will need when enabling the MSFT family.
A not exactly precise execution of
find * -name "*.inf" -exec grep -H "RVCT" {} \; | grep "|" | grep "\.asm" | wc -l
suggests 50 source files are affected in edk2. A further 6 in
edk2-platforms.
Hence, my preferred obsoletion path for RVCT would mean the family
(and at least one toolchain profile) remaining in the tree until
the Visual Studio enablement has switched the source files to MSFT.
Best Regards,
Leif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
2019-08-08 9:55 ` [edk2-devel] " Leif Lindholm
2019-08-08 10:51 ` Liming Gao
@ 2019-08-08 20:46 ` Laszlo Ersek
1 sibling, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2019-08-08 20:46 UTC (permalink / raw)
To: devel, leif.lindholm, shenglei.zhang
Cc: Bob Feng, Liming Gao, Ard Biesheuvel, Eugene Cohen
On 08/08/19 11:55, Leif Lindholm wrote:
> Hi Shenglei,
>
> On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
>> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
>> in tools_def.template. These tool chains are for ARM and AARCH64 only.
>> There is no change recently and they are not used.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
>
> This still does not address my comment in the BZ that deleting all
> RVCT profiles before full VS support is enabled for (32-bit) ARM, we
> orphan an awful lot of .asm files.
>
> This may not have much of a practical effect, since I doubt anyone is
> using these toolchains today - but it does prevent someone from
> actively going through and testing future updates (where before, they
> may just have neglected to do so).
>
> This point needs discussing rather than ignoring, and I think we're
> getting too close to the freeze to consider the patch to go in as is
> at this point.
>
> Whenever this patch does go in should be in the week after a stable
> tag is made, to give plenty of time for anyone affected to shout
> before the next stable tag is made.
>
> After the 2019.08 stable tag has been made, I am happy for a patch
> going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.
Tacking on a small technicality: this should be implemented with at
least three patches in a series (one per toolchain removed), and each
subject line should identify the toolchain being removed. The current
subject line is too generic.
Thanks
Laszlo
> The deletion of the final RVCT profile needs further discussion.
>
> Best Regards,
>
> Leif
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-08 20:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-08 8:09 [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template Zhang, Shenglei
2019-08-08 9:55 ` [edk2-devel] " Leif Lindholm
2019-08-08 10:51 ` Liming Gao
2019-08-08 11:30 ` Leif Lindholm
2019-08-08 20:46 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox