From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 08 Aug 2019 13:46:23 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id E4C3E7652E;
	Thu,  8 Aug 2019 20:46:22 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 5AE54100034E;
	Thu,  8 Aug 2019 20:46:21 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove tool chain in tools_def.template
To: devel@edk2.groups.io, leif.lindholm@linaro.org, shenglei.zhang@intel.com
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>, Eugene Cohen <eugene@hp.com>
References: <20190808080918.744-1-shenglei.zhang@intel.com>
 <20190808095518.GT25813@bivouac.eciton.net>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <22278c2c-dda6-8196-e296-5e76fed39cae@redhat.com>
Date: Thu, 8 Aug 2019 22:46:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190808095518.GT25813@bivouac.eciton.net>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 08 Aug 2019 20:46:23 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/08/19 11:55, Leif Lindholm wrote:
> Hi Shenglei,
> 
> On Thu, Aug 08, 2019 at 04:09:18PM +0800, Zhang, Shenglei wrote:
>> Remove definition of RVCT, RVCTLINUX, RVCTCYGWIN and CLANG35
>> in tools_def.template. These tool chains are for ARM and AARCH64 only.
>> There is no change recently and they are not used.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1750
> 
> This still does not address my comment in the BZ that deleting all
> RVCT profiles before full VS support is enabled for (32-bit) ARM, we
> orphan an awful lot of .asm files.
> 
> This may not have much of a practical effect, since I doubt anyone is
> using these toolchains today - but it does prevent someone from
> actively going through and testing future updates (where before, they
> may just have neglected to do so).
> 
> This point needs discussing rather than ignoring, and I think we're
> getting too close to the freeze to consider the patch to go in as is
> at this point.
> 
> Whenever this patch does go in should be in the week after a stable
> tag is made, to give plenty of time for anyone affected to shout
> before the next stable tag is made.
> 
> After the 2019.08 stable tag has been made, I am happy for a patch
> going in that deletes CLANG35, RVCTCYGWIN and *one*of* RVCT/RVCTLINUX.

Tacking on a small technicality: this should be implemented with at
least three patches in a series (one per toolchain removed), and each
subject line should identify the toolchain being removed. The current
subject line is too generic.

Thanks
Laszlo

> The deletion of the final RVCT profile needs further discussion.
> 
> Best Regards,
> 
> Leif
> 
> 
>