Hi Sahil,

Thank you for this patch.

On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote:

diff --git a/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec b/Silicon/ARM/Neov=
erseN1Soc/NeoverseN1Soc.dec
index c04162e7e7cd..cca5bf45db67 100644
--- a/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec
+++ b/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec
@@ -22,6 +22,8 @@
Include # Root include for the package=0D
=0D
[Guids.common]=0D
+ # ARM NeoverseN1Soc Platform Info descriptor=0D
+ gArmNeoverseN1SocPlatformInfoDescriptorGuid =3D { 0x9fa16eb5, 0xce13, 0x=
4d37, { 0x96, 0xf0, 0x0a, 0xb5, 0xf1, 0xab, 0xff, 0x01 } }=0D
gArmNeoverseN1SocTokenSpaceGuid =3D { 0xab93eb78, 0x60d7, 0x4099, { 0xac=
, 0xeb, 0x6d, 0xb5, 0x02, 0x58, 0x7c, 0x24 } }=0D
=0D
[PcdsFixedAtBuild]=0D
@@ -85,4 +87,5 @@
gArmNeoverseN1SocTokenSpaceGuid.PcdRemotePcieSegmentNumber|2|UINT32|0x00=
000051=0D
=0D
[Ppis]=0D
+ gArmNeoverseN1SocPlatformInfoDescriptorPpiGuid =3D { 0x21D04AD4, 0x4D23,=
0x426D, { 0x8D, 0x3E, 0x92, 0x23, 0x3E, 0xF4, 0xB9, 0x5E } }=0D
gArmNeoverseN1SocParameterPpiGuid =3D { 0x4DDD5A72, 0x31AD, 0x4B20, { 0x=
8F, 0x5F, 0xB3, 0xE8, 0x24, 0x6F, 0x80, 0x2B } }=0D

These changes should be part of patch 2/4. I am going to move this file to the correct patch before merging.

With that fixed,
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_