From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8C107740035 for ; Fri, 1 Mar 2024 14:19:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hAeFnJbxsl5hD0w/V90QCpc2L9PPNqyLWvoq/3n1SjA=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1709302756; v=1; b=g2et6dQC03S+5VvpqDb5xmWZpFlflvTi7g2NmA25Yq33jov1BT3PXRhFk9q4VFKIG3iqgk8R 4QkdyvEXsYGs0mZrJBur0Lb4HulLDUeCQ1MLCwplNfPwHV6++ijmfz4LFwx5WsRt5ubsHacX1kK 04KrL5kT8EBRnMZEye1GGQ5A= X-Received: by 127.0.0.2 with SMTP id XA1KYY7687511xVhaw0fQ7m5; Fri, 01 Mar 2024 06:19:16 -0800 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V4 3/4] Platform/ARM/N1Sdp: Enable N1SdpNtFwConfigPei PEI module for N1Sdp To: sahil ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.52) X-Originating-Platform: Mac Safari 17.1 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 01 Mar 2024 06:19:15 -0800 References: <20240104131616.474492-4-sahil@arm.com> In-Reply-To: <20240104131616.474492-4-sahil@arm.com> Message-ID: <22298.1709302755792837805@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IgqsEv42BJNNccaPfnBX8w99x7686176AA= Content-Type: multipart/alternative; boundary="Zc0gMouG6b73MHGByN88" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=g2et6dQC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --Zc0gMouG6b73MHGByN88 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sahil, Thank you for this patch. On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote: >=20 > diff --git a/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec > b/Silicon/ARM/Neov=3D > erseN1Soc/NeoverseN1Soc.dec > index c04162e7e7cd..cca5bf45db67 100644 > --- a/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec > +++ b/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec > @@ -22,6 +22,8 @@ > Include # Root include for the package=3D0D > =3D0D > [Guids.common]=3D0D > + # ARM NeoverseN1Soc Platform Info descriptor=3D0D > + gArmNeoverseN1SocPlatformInfoDescriptorGuid =3D3D { 0x9fa16eb5, 0xce13, > 0x=3D > 4d37, { 0x96, 0xf0, 0x0a, 0xb5, 0xf1, 0xab, 0xff, 0x01 } }=3D0D > gArmNeoverseN1SocTokenSpaceGuid =3D3D { 0xab93eb78, 0x60d7, 0x4099, { 0xa= c=3D > , 0xeb, 0x6d, 0xb5, 0x02, 0x58, 0x7c, 0x24 } }=3D0D > =3D0D > [PcdsFixedAtBuild]=3D0D > @@ -85,4 +87,5 @@ > gArmNeoverseN1SocTokenSpaceGuid.PcdRemotePcieSegmentNumber|2|UINT32|0x00= =3D > 000051=3D0D > =3D0D > [Ppis]=3D0D > + gArmNeoverseN1SocPlatformInfoDescriptorPpiGuid =3D3D { 0x21D04AD4, > 0x4D23,=3D > 0x426D, { 0x8D, 0x3E, 0x92, 0x23, 0x3E, 0xF4, 0xB9, 0x5E } }=3D0D > gArmNeoverseN1SocParameterPpiGuid =3D3D { 0x4DDD5A72, 0x31AD, 0x4B20, { 0= x=3D > 8F, 0x5F, 0xB3, 0xE8, 0x24, 0x6F, 0x80, 0x2B } }=3D0D These changes should be part of patch 2/4. I am going to move this file to = the correct patch before merging. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116255): https://edk2.groups.io/g/devel/message/116255 Mute This Topic: https://groups.io/mt/103521646/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --Zc0gMouG6b73MHGByN88 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sahil,

Thank you for this patch.

On Thu, Jan 4, 20= 24 at 05:16 AM, sahil wrote:
diff --git a/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec b/Sili= con/ARM/Neov=3D
erseN1Soc/NeoverseN1Soc.dec
index c04162e7e7cd..c= ca5bf45db67 100644
--- a/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec+++ b/Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec
@@ -22,6 +22,8 @= @
Include # Root include for the package=3D0D
=3D0D
[Guids.c= ommon]=3D0D
+ # ARM NeoverseN1Soc Platform Info descriptor=3D0D
+= gArmNeoverseN1SocPlatformInfoDescriptorGuid =3D3D { 0x9fa16eb5, 0xce13, 0x= =3D
4d37, { 0x96, 0xf0, 0x0a, 0xb5, 0xf1, 0xab, 0xff, 0x01 } }=3D0DgArmNeoverseN1SocTokenSpaceGuid =3D3D { 0xab93eb78, 0x60d7, 0x4099, { 0x= ac=3D
, 0xeb, 0x6d, 0xb5, 0x02, 0x58, 0x7c, 0x24 } }=3D0D
=3D0D[PcdsFixedAtBuild]=3D0D
@@ -85,4 +87,5 @@
gArmNeoverseN1SocTo= kenSpaceGuid.PcdRemotePcieSegmentNumber|2|UINT32|0x00=3D
000051=3D0D=3D0D
[Ppis]=3D0D
+ gArmNeoverseN1SocPlatformInfoDescriptorPp= iGuid =3D3D { 0x21D04AD4, 0x4D23,=3D
0x426D, { 0x8D, 0x3E, 0x92, 0x23,= 0x3E, 0xF4, 0xB9, 0x5E } }=3D0D
gArmNeoverseN1SocParameterPpiGuid =3D= 3D { 0x4DDD5A72, 0x31AD, 0x4B20, { 0x=3D
8F, 0x5F, 0xB3, 0xE8, 0x24, 0= x6F, 0x80, 0x2B } }=3D0D
These changes should be part of patch 2/4. I am going to move this file to = the correct patch before merging.

With that fixed,
Reviewed= -by: Sami Mujawar <sami.mujawar@arm.com> 

Regards,
Sami Mujawar

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116255) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--Zc0gMouG6b73MHGByN88--