From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.85]) by mx.groups.io with SMTP id smtpd.web11.698.1583190508386134261 for ; Mon, 02 Mar 2020 15:08:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=Ae7t8xSn; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.220.85, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jGqJP7Gdfk+u6wJpESSD922mafjdoepGBbgm0KJGopG6qaYyfR/vuBh6kH2cvyQ1PdafBN/dacNGJbxHJN5/X88qvGUEjk8z3+YZvt+1FUoUV0VGuHejrqhOclWQwvXtWTOgThBWgiGkjp8idIHamhr94QCB9P8yGbeApiN7u8oIANwZdrr1oZ7jiJYkpb+fhDXRxcZw/7/Alz/mlAmQxNskoUGncShkgqyiWFkkBCTjDiE3i6JiMAOHiu9Wv/y3BfrAvJZy9VHq+eEc4wukmqWeo5j0NCZ41V3UX+rJc70Z/YT06t00RVG/n5o3sP2s9J8wCVE57BlsHBZiDZYJRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fM6URT25KJh4c4drGE22greSIOsEkDgdgfMADFSiomg=; b=lN6cij8ZcTURjLWS3lIAf7EMEopMFjRuf0ssRvr35TvKyWmXqRPOx+47dvE31COBzmfrHv2yX+NRI1o6glXzK2/+fwBN9CKobnVFpaTJg8HgoxfSCD80J9CYdmHgaYLtz1y30PG9TMRYWxYnxuaDZlqyeXelprdPg9r50AayzB8WGEeyK5RCe+tMF4dBkl3boJ+ODksASRBY9mqBRv/Sw9hFMS7zkvemrQDOs5lXhovIdxzTEw91X/eC0nfUS48MQHyITqSyK5cDqj2Z65LtIm0Q5QkEnDbNQZVvx79KmY1YwlXd1gOsK8wdmDNrc7kmWsss8iJhGFUa2j9BaQk4TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fM6URT25KJh4c4drGE22greSIOsEkDgdgfMADFSiomg=; b=Ae7t8xSndu9z9RwUlfY8xLk+sPkmuMCMsfA/WNvtdcs6VtxTu+n2TsSizT27HrrxGx8waVScwJQiRnhUIHPAG/b4k1lpHOELj9Jz8+G3gOUo7EH1wEdMa8MUQdV+uboPF1Hw9yzYtV45Z6s6dj04tarbacLWamOmMhH3s7xusGc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) by DM6PR12MB4201.namprd12.prod.outlook.com (2603:10b6:5:216::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 23:08:27 +0000 Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::f0f9:a88f:f840:2733]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::f0f9:a88f:f840:2733%7]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 23:08:27 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh Subject: [PATCH v5 30/42] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled Date: Mon, 2 Mar 2020 17:07:01 -0600 Message-Id: <22374fae1fe81f89d0c382ec3945f9ff4c0d38a6.1583190432.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-ClientProxiedBy: DM5PR2001CA0013.namprd20.prod.outlook.com (2603:10b6:4:16::23) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by DM5PR2001CA0013.namprd20.prod.outlook.com (2603:10b6:4:16::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.16 via Frontend Transport; Mon, 2 Mar 2020 23:07:56 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8d659998-3464-42a5-b2c0-08d7befe8bac X-MS-TrafficTypeDiagnostic: DM6PR12MB4201:|DM6PR12MB4201: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 033054F29A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(199004)(189003)(66946007)(8936002)(54906003)(316002)(81156014)(81166006)(6486002)(6916009)(6666004)(66556008)(8676002)(4326008)(66476007)(52116002)(7696005)(2616005)(5660300002)(2906002)(36756003)(186003)(966005)(86362001)(478600001)(16526019)(26005)(956004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB4201;H:DM6PR12MB3163.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JwnXDKkx1aoo4xp4AZlBrBWZrMrzdAyTURbyZ8CRxb1WynvRT/e95HUqaJ1xBMux3TH9TG8BuPyzb2OWoUQhNJ/F82dv+H8jVKNLkHvn28On8se8FI7jYCjSfcXVIH+sU4YgD/hLwfLQqM4f8IibbimswEA8hlvb6QFT3B3CNGwBMgXSPFE0iQbidlUAaIYIUEHTrlclERuYT0730SSC2A5Faq8ewWU4P/vsU/bH/q+cTX0R4sLhVB1w1wKh94akWwlmoJQ2va8eOq8B+FwJo1N/dvxgr7xAxXwkaUKk2V5YVfUU6gnpWxbEV2vBErZnfJQdkhnNUXhH/wi5euAEO8wxK2CVtXZyYdFJ97vOBWRpgDaTL6O5swwvjiyR6wHh8vGXAJEs005/1XUh8WWtP7LDThegcHmnHdKzGmz4bnzb153jbdtxCPzh8y/i+jlbVIxLxXPWfIyjZfDmjgp2MqUH6W54bjDZoW/6suF2OuF1YuMaJxWBuMsZlAs/VU2FuEJKeTEWU66ay7FahRunNQ== X-MS-Exchange-AntiSpam-MessageData: Y4tORd51GcBNYfAT2FMIsilvY/9tBBL3bPt8YMzUCIfqug01Yp+tP7nFHNfl3RaF8nx2tLM4skpgpriBlhCfe3j6lKOL+7dXGb74btYF/Wb1hIyXa9zjk2kAninmStQp7YihTQv78hgxgQfd/eQ3NA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d659998-3464-42a5-b2c0-08d7befe8bac X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 23:07:57.2265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iv3DKpe0c3dBnspYOCZBQuq2ohdQjLWEq3nDElx94NlzEzcT+9tEqMSW7gYfYZuZwBK9A4E7SO2kS3JvVdC/lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4201 Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be able to handle the exception. Move the GDT into RAM so it can be accessed without error when running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/AmdSev.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index 5f0946763507..38885de359af 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -39,6 +39,8 @@ AmdSevEsInitialize ( PHYSICAL_ADDRESS GhcbBasePa; UINTN GhcbPageCount; RETURN_STATUS PcdStatus, DecryptStatus; + IA32_DESCRIPTOR Gdtr; + VOID *Gdt; if (!MemEncryptSevEsIsEnabled ()) { return; @@ -76,6 +78,22 @@ AmdSevEsInitialize ( (UINT64)GhcbPageCount, GhcbBase)); AsmWriteMsr64 (MSR_SEV_ES_GHCB, GhcbBasePa); + + // + // The SEV support will clear the C-bit from non-RAM areas. The early GDT + // lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT + // will be read as un-encrypted even though it was created before the C-bit + // was cleared (encrypted). This will result in a failure to be able to + // handle the exception. + // + AsmReadGdtr (&Gdtr); + + Gdt = AllocatePages (EFI_SIZE_TO_PAGES ((UINTN) Gdtr.Limit + 1)); + ASSERT (Gdt != NULL); + + CopyMem (Gdt, (VOID *) Gdtr.Base, Gdtr.Limit + 1); + Gdtr.Base = (UINTN) Gdt; + AsmWriteGdtr (&Gdtr); } /** -- 2.17.1