* [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
@ 2023-11-17 10:05 Shenbagadevi R via groups.io
2024-04-15 5:33 ` Sainadh Nagolu via groups.io
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Shenbagadevi R via groups.io @ 2023-11-17 10:05 UTC (permalink / raw)
To: devel@edk2.groups.io, Shenbagadevi R
Cc: gaoliming@byosoft.com.cn, Sainadh Nagolu, Sundaresan S,
Srinivasan Mani, Ramesh R
As per Smbios 3.7.0 spec, added CXL 3.0 support in Type 9, also added
PMIC & RCD manufacturer ID and Revision information in Type17.
Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
CC: Gaoliming <gaoliming@byosoft.com.cn>
CC: Sainadh N <sainadhn@ami.com>
CC: Sundaresan S <sundaresans@ami.com>
CC: Srinivasan M <srinivasanm@ami.com>
CC: Ramesh R <rameshr@ami.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 56cec615a0..cfefc2fa52 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
(C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
-Copyright (c) 1985 - 2022, American Megatrends International LLC.<BR>
+Copyright (c) 1985 - 2023, American Megatrends International LLC.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -1509,7 +1509,7 @@ typedef struct {
UINT8 AsyncSurpriseRemoval : 1;
UINT8 FlexbusSlotCxl10Capable : 1;
UINT8 FlexbusSlotCxl20Capable : 1;
- UINT8 Reserved : 1; ///< Set to 0.
+ UINT8 FlexbusSlotCxl30Capable : 1; ///SMBIOS spec 3.7.0 updated CXL 3.0 support
} MISC_SLOT_CHARACTERISTICS2;
///
@@ -2012,6 +2012,13 @@ typedef struct {
//
UINT32 ExtendedSpeed;
UINT32 ExtendedConfiguredMemorySpeed;
+ //
+ // Add for smbios 3.7.0
+ //
+ UINT16 Pmic0ManufacturerID;
+ UINT16 Pmic0RevisionNumber;
+ UINT16 RcdManufacturerID;
+ UINT16 RcdRevisionNumber;
} SMBIOS_TABLE_TYPE17;
///
--
2.38.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111430): https://edk2.groups.io/g/devel/message/111430
Mute This Topic: https://groups.io/mt/102698985/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
2023-11-17 10:05 [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec Shenbagadevi R via groups.io
@ 2024-04-15 5:33 ` Sainadh Nagolu via groups.io
2024-04-15 6:32 ` 回复: " gaoliming via groups.io
[not found] ` <17C66074E9D52EF0.8775@groups.io>
2 siblings, 0 replies; 4+ messages in thread
From: Sainadh Nagolu via groups.io @ 2024-04-15 5:33 UTC (permalink / raw)
To: Shenbagadevi R, devel
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
Hi Liming,
Please help to review this patch and include Smbios 3.7.0 spec update changes.
Thanks,
sainadh.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117753): https://edk2.groups.io/g/devel/message/117753
Mute This Topic: https://groups.io/mt/102698985/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 913 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
2023-11-17 10:05 [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec Shenbagadevi R via groups.io
2024-04-15 5:33 ` Sainadh Nagolu via groups.io
@ 2024-04-15 6:32 ` gaoliming via groups.io
[not found] ` <17C66074E9D52EF0.8775@groups.io>
2 siblings, 0 replies; 4+ messages in thread
From: gaoliming via groups.io @ 2024-04-15 6:32 UTC (permalink / raw)
To: devel, shenbagadevir
Cc: 'Sainadh Nagolu', 'Sundaresan S',
'Srinivasan Mani', 'Ramesh R'
Shenbagadevi:
I think you still need to update ShellPkg SmbiosView to support the
updated TYPE17.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Shenbagadevi
> R via groups.io
> 发送时间: 2023年11月17日 18:05
> 收件人: devel@edk2.groups.io; Shenbagadevi R <shenbagadevir@ami.com>
> 抄送: gaoliming@byosoft.com.cn; Sainadh Nagolu <sainadhn@ami.com>;
> Sundaresan S <sundaresans@ami.com>; Srinivasan Mani
> <srinivasanm@ami.com>; Ramesh R <rameshr@ami.com>
> 主题: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
>
> As per Smbios 3.7.0 spec, added CXL 3.0 support in Type 9, also added
> PMIC & RCD manufacturer ID and Revision information in Type17.
>
> Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
>
> CC: Gaoliming <gaoliming@byosoft.com.cn>
> CC: Sainadh N <sainadhn@ami.com>
> CC: Sundaresan S <sundaresans@ami.com>
> CC: Srinivasan M <srinivasanm@ami.com>
> CC: Ramesh R <rameshr@ami.com>
>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 56cec615a0..cfefc2fa52 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2023, Intel Corporation. All rights
> reserved.<BR>
> (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
>
> (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
>
> Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
>
> -Copyright (c) 1985 - 2022, American Megatrends International LLC.<BR>
>
> +Copyright (c) 1985 - 2023, American Megatrends International LLC.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
>
> **/
>
> @@ -1509,7 +1509,7 @@ typedef struct {
> UINT8 AsyncSurpriseRemoval : 1;
>
> UINT8 FlexbusSlotCxl10Capable : 1;
>
> UINT8 FlexbusSlotCxl20Capable : 1;
>
> - UINT8 Reserved : 1; ///< Set to 0.
>
> + UINT8 FlexbusSlotCxl30Capable : 1; ///SMBIOS spec 3.7.0 updated
> CXL 3.0 support
>
> } MISC_SLOT_CHARACTERISTICS2;
>
>
>
> ///
>
> @@ -2012,6 +2012,13 @@ typedef struct {
> //
>
> UINT32 ExtendedSpeed;
>
> UINT32
> ExtendedConfiguredMemorySpeed;
>
> + //
>
> + // Add for smbios 3.7.0
>
> + //
>
> + UINT16
> Pmic0ManufacturerID;
>
> + UINT16
> Pmic0RevisionNumber;
>
> + UINT16
> RcdManufacturerID;
>
> + UINT16
> RcdRevisionNumber;
>
> } SMBIOS_TABLE_TYPE17;
>
>
>
> ///
>
> --
> 2.38.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117757): https://edk2.groups.io/g/devel/message/117757
Mute This Topic: https://groups.io/mt/105531068/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
[not found] ` <17C66074E9D52EF0.8775@groups.io>
@ 2024-04-30 6:27 ` gaoliming via groups.io
0 siblings, 0 replies; 4+ messages in thread
From: gaoliming via groups.io @ 2024-04-30 6:27 UTC (permalink / raw)
To: devel, gaoliming, shenbagadevir
Cc: 'Sainadh Nagolu', 'Sundaresan S',
'Srinivasan Mani', 'Ramesh R'
I see your patch in ShellPkg. For this change in MdePkg, Reviewed-by: Liming
Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
> groups.io
> 发送时间: 2024年4月15日 14:33
> 收件人: devel@edk2.groups.io; shenbagadevir@ami.com
> 抄送: 'Sainadh Nagolu' <sainadhn@ami.com>; 'Sundaresan S'
> <sundaresans@ami.com>; 'Srinivasan Mani' <srinivasanm@ami.com>;
> 'Ramesh R' <rameshr@ami.com>
> 主题: 回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0
> Spec
>
> Shenbagadevi:
> I think you still need to update ShellPkg SmbiosView to support the
> updated TYPE17.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> Shenbagadevi
> > R via groups.io
> > 发送时间: 2023年11月17日 18:05
> > 收件人: devel@edk2.groups.io; Shenbagadevi R
> <shenbagadevir@ami.com>
> > 抄送: gaoliming@byosoft.com.cn; Sainadh Nagolu <sainadhn@ami.com>;
> > Sundaresan S <sundaresans@ami.com>; Srinivasan Mani
> > <srinivasanm@ami.com>; Ramesh R <rameshr@ami.com>
> > 主题: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
> >
> > As per Smbios 3.7.0 spec, added CXL 3.0 support in Type 9, also added
> > PMIC & RCD manufacturer ID and Revision information in Type17.
> >
> > Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
> >
> > CC: Gaoliming <gaoliming@byosoft.com.cn>
> > CC: Sainadh N <sainadhn@ami.com>
> > CC: Sundaresan S <sundaresans@ami.com>
> > CC: Srinivasan M <srinivasanm@ami.com>
> > CC: Ramesh R <rameshr@ami.com>
> >
> > ---
> > MdePkg/Include/IndustryStandard/SmBios.h | 11 +++++++++--
> > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > b/MdePkg/Include/IndustryStandard/SmBios.h
> > index 56cec615a0..cfefc2fa52 100644
> > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2023, Intel Corporation. All rights
> > reserved.<BR>
> > (C) Copyright 2015-2017 Hewlett Packard Enterprise Development
> LP<BR>
> >
> > (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development
> LP<BR>
> >
> > Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
> >
> > -Copyright (c) 1985 - 2022, American Megatrends International LLC.<BR>
> >
> > +Copyright (c) 1985 - 2023, American Megatrends International LLC.<BR>
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >
> >
> > **/
> >
> > @@ -1509,7 +1509,7 @@ typedef struct {
> > UINT8 AsyncSurpriseRemoval : 1;
> >
> > UINT8 FlexbusSlotCxl10Capable : 1;
> >
> > UINT8 FlexbusSlotCxl20Capable : 1;
> >
> > - UINT8 Reserved : 1; ///< Set to 0.
> >
> > + UINT8 FlexbusSlotCxl30Capable : 1; ///SMBIOS spec 3.7.0 updated
> > CXL 3.0 support
> >
> > } MISC_SLOT_CHARACTERISTICS2;
> >
> >
> >
> > ///
> >
> > @@ -2012,6 +2012,13 @@ typedef struct {
> > //
> >
> > UINT32 ExtendedSpeed;
> >
> > UINT32
> > ExtendedConfiguredMemorySpeed;
> >
> > + //
> >
> > + // Add for smbios 3.7.0
> >
> > + //
> >
> > + UINT16
> > Pmic0ManufacturerID;
> >
> > + UINT16
> > Pmic0RevisionNumber;
> >
> > + UINT16
> > RcdManufacturerID;
> >
> > + UINT16
> > RcdRevisionNumber;
> >
> > } SMBIOS_TABLE_TYPE17;
> >
> >
> >
> > ///
> >
> > --
> > 2.38.0.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
you
> are
> > on notice that any distribution of this message, in any form, is
strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> >
> >
> >
> >
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118418): https://edk2.groups.io/g/devel/message/118418
Mute This Topic: https://groups.io/mt/105816498/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-30 6:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-17 10:05 [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec Shenbagadevi R via groups.io
2024-04-15 5:33 ` Sainadh Nagolu via groups.io
2024-04-15 6:32 ` 回复: " gaoliming via groups.io
[not found] ` <17C66074E9D52EF0.8775@groups.io>
2024-04-30 6:27 ` gaoliming via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox