From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9F8CF78003C for ; Sun, 31 Mar 2024 12:01:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iVTkeVUyUtRrHUlpxTiUoobjo20xPsJWs5Q6NotvFn4=; c=relaxed/simple; d=groups.io; h=Received-SPF:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711886501; v=1; b=x70CiwL4nwj0v0U/ZbwHQHizrqYrptp+a+DmKVD+lWGpJXiL3vwjEHdxJK3lWTSDsrDGUfux sG75ZJIl5idxYwKbymmkiI+6hA4yQCTLDPxon3tGXbwzPUkybk+ocXCPXEPSMcSOTjq3FAuxVyZ cDnJ0f/ayTgwtImxXBzqSaG33/uWJFDzXd4TOr79TolaKAgsYZ4fR63rNvcr6UPtiK9o4yuU5bY 8ejgPfvPsNuLXdQs1KIGpMTcCMsAajH0JSohH51BJRH+mwi1Zsl4u1HNIOxuaScezFo+810XBBD DgeOydR+qx6LxbK6Cvs14rW2H+GkDW2EscxQaJRAeTUqQ== X-Received: by 127.0.0.2 with SMTP id ee8oYY7687511xjXiNV6MoMe; Sun, 31 Mar 2024 05:01:41 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.54]) by mx.groups.io with SMTP id smtpd.web10.15792.1711886500348311242 for ; Sun, 31 Mar 2024 05:01:40 -0700 X-Received: from AS4P190CA0001.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5de::7) by AS8PR08MB6134.eurprd08.prod.outlook.com (2603:10a6:20b:291::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45; Sun, 31 Mar 2024 12:01:36 +0000 X-Received: from AM4PEPF00027A67.eurprd04.prod.outlook.com (2603:10a6:20b:5de:cafe::79) by AS4P190CA0001.outlook.office365.com (2603:10a6:20b:5de::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Sun, 31 Mar 2024 12:01:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00027A67.mail.protection.outlook.com (10.167.16.84) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sun, 31 Mar 2024 12:01:36 +0000 X-Received: ("Tessian outbound dc0a9029eb2c:v300"); Sun, 31 Mar 2024 12:01:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 70c0d8b71447a167 X-CR-MTA-TID: 64aa7808 X-Received: from db321fb7be05.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 89AFC5CF-37E1-431C-ADBF-B8D902D8BED8.1; Sun, 31 Mar 2024 12:01:30 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id db321fb7be05.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 31 Mar 2024 12:01:30 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GVXPR08MB10430.eurprd08.prod.outlook.com (2603:10a6:150:14e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.42; Sun, 31 Mar 2024 12:01:27 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c%5]) with mapi id 15.20.7409.042; Sun, 31 Mar 2024 12:01:27 +0000 Message-ID: <22544597-85ab-478c-b315-e9a2e367cb67@arm.com> Date: Sun, 31 Mar 2024 13:01:25 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 To: Prabin CA , devel@edk2.groups.io CC: Ard Biesheuvel , Leif Lindholm , Thomas Abraham , "nd@arm.com" References: <20240311131416.823580-1-prabin.ca@arm.com> <20240311131416.823580-3-prabin.ca@arm.com> From: "Sami Mujawar" In-Reply-To: <20240311131416.823580-3-prabin.ca@arm.com> X-ClientProxiedBy: LO4P123CA0333.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GVXPR08MB10430:EE_|AM4PEPF00027A67:EE_|AS8PR08MB6134:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: esyVFiAewI4ejIaPs6ddSs1bzW+pwLSJqvze2CTeHJ/CsgDMw06NdT3LcAs007hwXVZH5YZXJ9qg03Brf2r2Cgkw2/88uQNz9c+WhfzmFeNcZ/KqvfjgmG3/rmZLVWZqBAsOgjYP4glsf9MXkx8OYFF1FW6THMozjpdhSogxFjJPgMQ0YhkuqMQeXm2nUAMU9c2bH5BZkGgKgyxLNk1GiZ+kqfqvsIinGCOMKN6m/ae9yvhvn4TjBASfHxJhyjBWa3ut47pf+44P67/3E16ey3JjcZ4W0z1YLA921WZSeukiO+rVhLYg/igcmv7FcdRiLVZDTO3uECCE7MPpK1pTnkcKxdtV+LjqruWB1+YB0BUwSXaUhcgeJw0AZilC9bLinx4uLdTsozX8Zj0PxRcyyXDcquErYbkVLL8euHDHgUWRBsV4uBPvKbDDM41qs1OMdXUvA7pCTLH/d0SIJHGdIUNNbrpYbIWHrvF2LC9ZL3hZAdOLld+YphrW09+WN+7smH9ccy4SXVb8y2GCwMKMV1ZNBshFuVBEggncX4hkoHeaHgHWiqzdR6uGq/gck4Ad5lWOrYw3uSjv93iv/wCMOHb5qtIrVHRFVCrk3Rcl4ONG6rkHOUPyoUAtxCKJTT9Uw8jnTT0O8hK5a7BddoBz38sCCF7qF4SPOBwo8tbxBHw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10430 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A67.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fd25d8a-0c1c-403c-4c61-08dc517a50e8 X-Microsoft-Antispam-Message-Info: G6DSvlL9Xab2gSVr6s6cpTi4AsgB+OzuY54NeJZr2jSoYLCXkTM6FVcQmIM5Yzv4i81+/1327vTKtLEjH2et3OJIbJ+2fb6/X3RbrVIAa9onQNakfkNmQmD8aethzjdGF5oCdTcVF1XpouQOGwRlxrEl0OEIt8puopu68/sUf54Lnr9Cw4ncDcqIpSPLapUAYGf4NCxt6FX6roJVHZGl9ODk9sW6nQ4yGT7jM19LzzCC8wrfnKJhqkM3PQXP0hazm3YmIPGQoMWEOHveC9zgjnvLVyLL2z7YL79Lqeybt8YBvPsW1H6DnfQrGV7SYCGH5Re9nd/GUwob+ccNbn672ENkJ3uU7iQuRQOv9INrqUE3yR4VGPmt/wf1+r9KBXewB9t8hVSqse8JaWMojXvgpZX+330BKVWKgJJNuMl41BIXufMOPXktdmrUVLALwg4DYqYg0AxRrBBr8mWWa2zwLLoa6VqretV9dg/yUjIkSPUdeXpmiugIWUe4+7Tng1ZAznON2DNWkUVyOiDJTOB1FYB1xfqU40DmL1pzSi48J+vJoeZpMobkFOFz5lc0W1H/sVXD6jHZq50OEEAJhNMnvY4Qnyqp1kcavDczTE6BfXHaVKHT/L1CoDrSnGyeboFb8QOMXqOkBllIZi1UQ7LnMeW3mRPjElUxqMRFC3ebAgpiWZRImPb9JtuTHJKNA4DFNgpKuRoIpmuXMbWSrC5LX8igWvBe1DEtUEVBDVhaVnS2Y8IW2DzLJuhjVO8qJ2Tx X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 12:01:36.4403 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fd25d8a-0c1c-403c-4c61-08dc517a50e8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A67.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6134 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 05:01:40 -0700 Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2Oz0WlEpuYzi4biw2Wvi6uHXx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=x70CiwL4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Prabin, Thank you for this patch. Minor, EDKII does not have u32 and u64 types, otherwise=C2=A0 these changes= =20 look good to me. I will reword the commit message before merging. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: > From: Vivek Gautam > > On RD-N2 and previous generation platforms, the base address was within > 32-bit region. However, on upcoming platforms, the SMMUv3 base address > is beyond 32-bit address region. So, update the datatype of SMMUv3 base > PCD. > > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/Sg= iPlatform.dec > index 103dff8471a7..4087ff6cad2e 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dec > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec > @@ -79,7 +79,7 @@ [PcdsFixedAtBuild] > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv|0|UINT32|0x00000014 > =20 > # SMMU > - gArmSgiTokenSpaceGuid.PcdSmmuBase|0|UINT32|0x0000001D > + gArmSgiTokenSpaceGuid.PcdSmmuBase|0|UINT64|0x0000001D > gArmSgiTokenSpaceGuid.PcdSmmuSize|0|UINT32|0x0000001E > =20 > # GPIO Controller > diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c b/P= latform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > index fa3cfbc730f6..62c212f3c5b0 100644 > --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2018-2023, ARM Limited. All rights reserved. > +* Copyright (c) 2018-2024, Arm Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -167,8 +167,8 @@ ArmPlatformGetVirtualMemoryMap ( > VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRI= BUTE_DEVICE; > =20 > // Sub System Peripherals - SMMU > - VirtualMemoryTable[++Index].PhysicalBase =3D FixedPcdGet32 (PcdSmmuBa= se); > - VirtualMemoryTable[Index].VirtualBase =3D FixedPcdGet32 (PcdSmmuBa= se); > + VirtualMemoryTable[++Index].PhysicalBase =3D FixedPcdGet64 (PcdSmmuBa= se); > + VirtualMemoryTable[Index].VirtualBase =3D FixedPcdGet64 (PcdSmmuBa= se); > VirtualMemoryTable[Index].Length =3D FixedPcdGet32 (PcdSmmuS= ize); > VirtualMemoryTable[Index].Attributes =3D ARM_MEMORY_REGION_ATTRI= BUTE_DEVICE; > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117261): https://edk2.groups.io/g/devel/message/117261 Mute This Topic: https://groups.io/mt/104862627/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-