Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

["Lendacky, Thomas" <thomas.lendacky@amd.com>]

On 5/5/20 8:53 PM, Dong, Eric wrote:
> 
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Laszlo Ersek
>> Sent: Tuesday, May 5, 2020 11:30 PM
>> To: Tom Lendacky <thomas.lendacky@amd.com>; Dong, Eric
>> <eric.dong@intel.com>; devel@edk2.groups.io
>> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
>> <ard.biesheuvel@linaro.org>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray
>> <ray.ni@intel.com>; Brijesh Singh <brijesh.singh@amd.com>; Wang, Jian J
>> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>> Subject: Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to
>> be used in support of SEV-ES
>>
>> On 05/04/20 18:41, Tom Lendacky wrote:
>>
>>> Is there an easy way to run everything that this link points, too? Is
>>> it just creating a pull request that does this? I don't want to take
>>> up a lot of your time, so if there's some documentation on how to run
>>> an integration test to find and fix issues like this, just point me to it.
>>
>> Just create a pull request; it will set off CI, and you can review VS build errors
>> there (if any).
>>
>> Your PR will automatically be closed (rejected) regardless of whether CI
>> succeeds or not. PRs are merged -- in fact, *auto*-merged, by the "mergify
>> bot" -- if and only if (a) the CI run succeeds, and (b) the PR has the "push"
>> label set.
>>
>> And only edk2 maintainers have permission to set the "push" label. Any PR
>> without the "push" label qualifies as a "personal test build". So you can freely
>> experiment with PRs, because you can't (even unwittingly) satisfy condition
>> (b).
>>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Development-&amp;data=02%7C01%7Cthomas.lendacky%40amd.com%7C9cff3475aff84a95728508d7f1604c99%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243268217382019&amp;sdata=3%2FIKB174QaVLaqO0u1gdrL0izXmhEZ%2Byvj3iC13UYBc%3D&amp;reserved=0
>> Process
>>
> 
> Thanks Laszlo for your explanation.
> 
> I found this patch serial is incompatible for the existed platforms. Can you help to fix the build failure for these platforms in https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-platforms&amp;data=02%7C01%7Cthomas.lendacky%40amd.com%7C9cff3475aff84a95728508d7f1604c99%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243268217382019&amp;sdata=jU0qrB%2BV6ZvFmPzjcxGo9o2Pu1%2FrhRW0gUZTMv%2BiXDQ%3D&amp;reserved=0
> 

I have fixed all of the build issues associated with the VS compiler using 
the pull request method that Laszlo mentioned. I then successfully built 
the RPi4 platform under GCC (build -n 32 -a AARCH64 -t GCC5 -p 
Platform/RaspberryPi/RPi4/RPi4.dsc) using the AARCH64 cross compiler.

Is there a particular platform that experiences an issue or are the 
failures related to the VS compiler errors that my next series will have 
fixed?

> I think you also needs to add an wiki page to explain what need to do if an platform needs to integrate your changes, also it's better to explain this feature in the page.
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki&amp;data=02%7C01%7Cthomas.lendacky%40amd.com%7C9cff3475aff84a95728508d7f1604c99%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243268217382019&amp;sdata=xLkoV4zWhxtsbqszqPc0lEAl%2BYLL%2B2wg1nIXql8a64E%3D&amp;reserved=0

I don't see any platform other than OVMF using this feature as it is a 
virtualization feature. Having said that I can add an explanation of what 
is needed should another virtualization platform be created under EDK2 
that wants to support SEV-ES. And, as you said, I can also explain the 
feature overall on the page.

> 
> 
> If you want to include this change in the next edk2 release, you need to add one item for it in the release plan page, sample can be found in below pages: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Release-Planning&amp;data=02%7C01%7Cthomas.lendacky%40amd.com%7C9cff3475aff84a95728508d7f1604c99%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637243268217382019&amp;sdata=kcDVjYHMS9bRRZOlKEk5ynFNT39AnxchJAMak%2Bn870I%3D&amp;reserved=0

Thanks. Is there anyone in particular that I need to request this feature 
be added?

Thanks,
Tom

> 
> 
> Thanks,
> Eric
> 
>> Thanks,
>> Laszlo
>>
>>
>>