public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Pete Batard <pete@akeo.ie>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger
Date: Fri, 11 Nov 2016 15:50:58 +0000	[thread overview]
Message-ID: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> (raw)

The EBC Debugger [1], which was present in Tianocore [2], is an 
invaluable tool for EBC development.
This patch adds it back into the EDK2, allowing, for instance, the 
compilation of an AARCH64 EBC debugger.

Note 1: The patch is split in two, so that the changes to the existing 
EbcDxe code are clearer.

Note 2: The diff between the original and the new sources can be found 
at [3]. Most of the changes were for whitespaces/API names/compiler 
warnings, with the notable exception of:
- Bumping of the EBCdebugger version to 1.0.
- Dropping of the DebuggerConfiguration protocol (which would require 
introducing a new global GUID and protocol). I didn't see it as 
particularly useful to caary on and would rather see if there is actual 
demand for it, before adding it back.
- Add of an EFIAPI qualifier for most of the support functions, 
especially the ones dealing with VPrint() ouput. This is required to 
avoid garbage text output in some instances.
- Fixing of the erroneous display of 32 and 64 bit indexes in the 
disassembly.
- Replacement of one assignation with CopyMem() to avoid an intrinsic 
memcpy().

Note 3: I tested the debugger built for AARCH64 and X64 using gcc on 
Linux (Debian/Sid) as well as the one built for IA32 and X64 using 
VS2015 on Windows. I haven't tested an IA64 version for lack of a toolchain.

Regards,

/Pete

[1] http://www.uefi.org/node/550
[2] https://github.com/tianocore/edk/tree/master/Sample/Universal/Ebc/Dxe
[3] 
https://github.com/pbatard/EbcDebugger/commit/906e87ed6ceab1c361ba6f681bef48179baf549e


             reply	other threads:[~2016-11-11 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 15:50 Pete Batard [this message]
2016-11-11 17:41 ` [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger Kinney, Michael D
2016-11-11 18:13   ` Pete Batard
2016-11-11 23:48 ` Yao, Jiewen
2016-11-12  0:43   ` Pete Batard
2016-11-12  7:48     ` Yao, Jiewen
2016-11-12 12:46       ` Pete Batard
2016-11-12 13:43         ` Yao, Jiewen
2016-11-12 19:49           ` Yao, Jiewen
2016-11-12 21:44             ` Yao, Jiewen
2016-11-12 22:17               ` Pete Batard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox