From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 05F7181E1A for ; Fri, 11 Nov 2016 07:50:58 -0800 (PST) Received: by mail-wm0-x243.google.com with SMTP id m203so8663420wma.3 for ; Fri, 11 Nov 2016 07:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:subject:to:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=AOPVRkcQzu1ts8/jcd+mgTS7LcBFl9BminAFyg6XlB8=; b=QKGE5ixrNk5CVjczyNDv2TNm+eomz24BB6mqN0nxiR4hacjygQN9cdFBOwDZUMmk9x pNOb/BRxUhpfZhTO4BNSNPtleJ+n7exx+YLs7OY2ZWwNSMg4g06mweEzIO5e6Go2urvb h9kDeNlc4hv9OYi9YTUwAH6nBqgyDNEkoRHcOpSTSZSBlTbwbee5vc3pTMTfLTwVkAIW t6jncMlC9XOCRqDzMRfArwlE6qTFInB0ByZ6SKfjS4WZ/4eO/yIemHvF2RujDLJwZDa0 LsXYR/j7P6WvdFpDtHeXSjOTMqcF/XO5/V2giOLk2DE5kBi31EozSn1EGFAsFLSbzrGg pezg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=AOPVRkcQzu1ts8/jcd+mgTS7LcBFl9BminAFyg6XlB8=; b=RKL0GqlJEhzMAy5GwqRzly76u9B97xCol17quzAHvTX7xq0bKZrbEau3NKWWRe9qNc frVHKK4uA7q1AexFv7xwsUkTgYo2WBrLS4a9V/XXQqKM6BF9jLk/4weDRm9JH53TCbQz ROlV4kY+zdWeyimpfrOedoI8JrDRzyiTw0iLo5cfbNWX/e6K3J96fIJKcD1xJij4tORq PU7iHJfXug5Ubf6crewHlkEjNtrwLGUNIH31WqUOeW4eJ64h9blL91F6lPbXs7N5Xlfb AQGJLwABbWoINUAENCGg+dKGGNTyxcBnYZ6Ytrs2r5QCtNEpkdzudUdi/rs8W22P4dUi mjJw== X-Gm-Message-State: ABUngvd99qYv5dA59gc/ms66GPa3CA9JfeSDna1v/BZBK4dflnj/U3mMaVywO5yGL+N45A== X-Received: by 10.28.198.67 with SMTP id w64mr34672206wmf.13.1478879460034; Fri, 11 Nov 2016 07:51:00 -0800 (PST) Received: from [10.0.0.101] ([84.203.32.71]) by smtp.googlemail.com with ESMTPSA id x5sm9392044wje.36.2016.11.11.07.50.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Nov 2016 07:50:59 -0800 (PST) From: Pete Batard To: "edk2-devel@lists.01.org" Message-ID: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> Date: Fri, 11 Nov 2016 15:50:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 Subject: [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 15:50:58 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit The EBC Debugger [1], which was present in Tianocore [2], is an invaluable tool for EBC development. This patch adds it back into the EDK2, allowing, for instance, the compilation of an AARCH64 EBC debugger. Note 1: The patch is split in two, so that the changes to the existing EbcDxe code are clearer. Note 2: The diff between the original and the new sources can be found at [3]. Most of the changes were for whitespaces/API names/compiler warnings, with the notable exception of: - Bumping of the EBCdebugger version to 1.0. - Dropping of the DebuggerConfiguration protocol (which would require introducing a new global GUID and protocol). I didn't see it as particularly useful to caary on and would rather see if there is actual demand for it, before adding it back. - Add of an EFIAPI qualifier for most of the support functions, especially the ones dealing with VPrint() ouput. This is required to avoid garbage text output in some instances. - Fixing of the erroneous display of 32 and 64 bit indexes in the disassembly. - Replacement of one assignation with CopyMem() to avoid an intrinsic memcpy(). Note 3: I tested the debugger built for AARCH64 and X64 using gcc on Linux (Debian/Sid) as well as the one built for IA32 and X64 using VS2015 on Windows. I haven't tested an IA64 version for lack of a toolchain. Regards, /Pete [1] http://www.uefi.org/node/550 [2] https://github.com/tianocore/edk/tree/master/Sample/Universal/Ebc/Dxe [3] https://github.com/pbatard/EbcDebugger/commit/906e87ed6ceab1c361ba6f681bef48179baf549e