From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9AC502119358F for ; Mon, 3 Dec 2018 05:49:33 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35B82308624B; Mon, 3 Dec 2018 13:49:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-61.rdu2.redhat.com [10.10.120.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 936EC5C257; Mon, 3 Dec 2018 13:49:32 +0000 (UTC) To: Eric Jin References: <20181203075333.59712-1-eric.jin@intel.com> Cc: edk2-devel@lists.01.org From: Laszlo Ersek Message-ID: <22732d66-0578-bf26-c69a-7fe23ed4b801@redhat.com> Date: Mon, 3 Dec 2018 14:49:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181203075333.59712-1-eric.jin@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 03 Dec 2018 13:49:33 +0000 (UTC) Subject: Re: [edk2-test][v2 Patch 0/3] Add VerifySignature() Test X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2018 13:49:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/03/18 08:53, Eric Jin wrote: > This is the cover letter. > The series of patches are listed below. > > uefi-sct/SctPkg:Format code style in PKCS7Verify > uefi-sct/SctPkg:Add VerifySignature() Func Test > uefi-sct/SctPkg:Add VerifySignature() Conf Test > > > .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.c | 93 +- > .../EFI/Protocol/PKCS7Verify/BlackBoxTest/Guid.h | 192 +-- > .../PKCS7Verify/BlackBoxTest/Pkcs7BBTest.inf | 126 +- > .../BlackBoxTest/Pkcs7BBTestConformance.c | 1305 +++++++++------- > .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestData.c | 1568 +++++++++++++------- > .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestFunction.c | 553 ++++--- > .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.c | 458 +++--- > .../PKCS7Verify/BlackBoxTest/Pkcs7BBTestMain.h | 248 ++-- > 8 files changed, 2689 insertions(+), 1854 deletions(-) > A cover letter like this doesn't make any sense. - Please enable shallow threading for git-send-email, so that the patch emails are (direct) children of the cover letter. One of the goals of the cover letter is to group the patches under a common parent message. - The other purpose of cover letters is to summarize the goal of the patch series (high level problem statement, chosen solution, maybe mention one or two details if they are important). Thanks Laszlo