From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: Michael D Kinney <michael.d.kinney@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib
Date: Fri, 04 Nov 2022 07:44:52 -0700 [thread overview]
Message-ID: <22885.1667573092402501637@groups.io> (raw)
In-Reply-To: <20221104033056.1259-4-michael.d.kinney@intel.com>
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
There's a typo in UnitTestFrameworkPkg/ReadMe.md. You'll find it by searching for "ued".
The ReadMe.md updates are very helpful. Something else to consider would be a brief feature matrix at the top for the "framework" vs GoogleTest. I think it would be a little easier to parse which to choose than picking apart the key differences in the text.
[-- Attachment #2: Type: text/html, Size: 437 bytes --]
next prev parent reply other threads:[~2022-11-04 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 3:30 [Patch 0/7] Add GoogleTest to UnitTestFrameworkPkg Michael D Kinney
2022-11-04 3:30 ` [Patch 1/7] MdePkg/Include: Update Base.h to improve C++ compatibility Michael D Kinney
2022-11-04 3:30 ` [Patch 2/7] MdePkg/Include/Library: Undefine _ASSERT() if already defined Michael D Kinney
2022-11-04 3:30 ` [Patch 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib Michael D Kinney
2022-11-04 14:44 ` Michael Kubacki [this message]
2022-11-04 16:32 ` [edk2-devel] " Michael D Kinney
2022-11-04 3:30 ` [Patch 4/7] UnitTestFrameworkPkg/Library/CmockaLib: Enable symbol files Michael D Kinney
2022-11-04 14:45 ` [edk2-devel] " Michael Kubacki
2022-11-04 3:30 ` [Patch 5/7] .pytool: Add googletest submodule to CISettings.py Michael D Kinney
2022-11-04 14:46 ` [edk2-devel] " Michael Kubacki
2022-11-04 3:30 ` [Patch 6/7] BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml output Michael D Kinney
2022-11-04 13:30 ` Bob Feng
2022-11-04 3:30 ` [Patch 7/7] MdePkg/Test: Add port of BaseSafeIntLib unit tests to GoogleTest Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22885.1667573092402501637@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox