From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 88B7D209603C5 for ; Wed, 16 May 2018 02:29:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5196F7C6C2; Wed, 16 May 2018 09:29:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-6.rdu2.redhat.com [10.10.120.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 036A010EE6CF; Wed, 16 May 2018 09:29:24 +0000 (UTC) To: marcandre.lureau@redhat.com, edk2-devel@lists.01.org Cc: qemu-devel@nongnu.org, javierm@redhat.com, pjones@redhat.com, jiewen.yao@intel.com References: <20180515123007.10164-1-marcandre.lureau@redhat.com> From: Laszlo Ersek Message-ID: <229d0059-2ab4-bf2d-cbf5-9dca4ff978bd@redhat.com> Date: Wed, 16 May 2018 11:29:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180515123007.10164-1-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 09:29:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 16 May 2018 09:29:30 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 09:29:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Marc-André, On 05/15/18 14:30, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU > with TPM2 (I haven't tested TPM1, for lack of interest). I got the review of this patch series added to my TODO list, but I'll have to ask for your patience. :( >>From an extremely superficial skim: * please use the TopDirPkg/ModuleName: blah blah blah subject format, or more generally, if a module cannot be identified, TopDirPkg: blah blah blah * the subject line and the commit message shouldn't be wider than 74 chars; * edk2 uses two spaces for general indentation, and I'm noticing some inconsistency there (4 spaces like in QEMU). * Please consider formatting the patches with "--find-copies-harder" (although I can look at them with the same option after fetching the series from your repo). This option is usually helpful for reviewers when cloning and modifying modules cross-package. * Please consider adopting the git settings at , in particular: - "--stat=1000 --stat-graph-width=20", so that pathnames are not truncated in the diffstats, - the "xfuncname"-related settings, so that git diff hunk headers @@ are useful for DSC and INF files too, - the diff order file, so that files are listed in patches in logical order, going from abstract / descriptive (.inf, .h) to concrete / imperative (.c). Not much of a review, I know; this is all I can offer right now. If you have the time to respin just with these superficial changes, that might make my life easier. If you prefer to delay them, that's 100% fine too. Thanks Laszlo