From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.52888.1598879868796123543 for ; Mon, 31 Aug 2020 06:17:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=WKr3xy3W; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.66, mailfrom: pete@akeo.ie) Received: by mail-wm1-f66.google.com with SMTP id u18so5360935wmc.3 for ; Mon, 31 Aug 2020 06:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NwWX/LXQwma8F+lL3fWlzAI8jLOrjD0ga4NxTtOu7zo=; b=WKr3xy3WLnCUfhqwUoFG3MJs6x657KpuVe/Y+TzNkGROcB7SM7aZXaNy6irQ2yP93y HEjBDjS9emL3CrjWr2TvNpBD0zAf5hAk1LBhH6j+RvfOiTJ98E3a8c6yBwQMVMODcRN6 YaiAJBJGhpjF3iWWkATYes3kLq3euaBakVy6WmftOxAaJhd+1F2VlOVtggsOi3zWHc5a q3SbgJqHlAr8gPdeQfFSttUt7J7vnv7BcOkzwpyJONBSYOsunO6h+6yvG4gkH1+bfJ0X Mg8w7UUxI6tNHSEXVKtOKYGzIBHLhpuU2qt+BOd+enGHv1h9w3khyzkxcKNdlsvAVnU6 4MsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NwWX/LXQwma8F+lL3fWlzAI8jLOrjD0ga4NxTtOu7zo=; b=j/mQfIcjJrQOleLzy2w+eSBKzKFjXuFekc0kCAwvmyzl26WKo2aRTVWdxyoT11NFC2 dKllhn3B7FoBGKyFdGdI1Qp4pECfxKpjHohLSysQZbndIG4glOr7boSRYzwtuX1V6BdH gr2lsFezpU/I+zVreqk4/KXeVHdHPOrTry/8dRySE1bOPte1a1OzZvKKZWuHqEuzZR27 30j12yH63C0S4EDzJ9jSVnF6y4F29BtY+nDrk5CK2pdLnIHrl1nrO+tVXtHUl9rd3Wvl KZ0+ijMbDa8cVkzzTA3byb7GNDnG5PGxiZx2D09gMrFzNx+/IKP1yIqlgdhYo0n7lmzC N/dw== X-Gm-Message-State: AOAM531uuJ9BtoaF1fbOZUCT9vquOML0hI5xQ0XJlLWBTouTH3vB8nUI 2P2reRXTzBaDYzWN/o3Ierq3cg== X-Google-Smtp-Source: ABdhPJzxskqMe3NhCBaPsobJjcWcIZvo1xvEXu6d8WSpDGNsCQBMrwt4lIP1qyLF+aOZywOh8pssoA== X-Received: by 2002:a1c:f017:: with SMTP id a23mr1286757wmb.164.1598879867225; Mon, 31 Aug 2020 06:17:47 -0700 (PDT) Return-Path: Received: from [10.0.0.130] ([84.203.85.10]) by smtp.googlemail.com with ESMTPSA id f17sm12394016wru.13.2020.08.31.06.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2020 06:17:46 -0700 (PDT) Subject: Re: [PATCH v3 5/5] Platform/RaspberryPi: Trivial whitespace cleanup To: Jeremy Linton , devel@edk2.groups.io Cc: Leif Lindholm , Andrei Warkentin , Ard Biesheuvel , Samer El-Haj-Mahmoud References: <20200828220215.101919-1-jeremy.linton@arm.com> <20200828220215.101919-6-jeremy.linton@arm.com> From: "Pete Batard" Message-ID: <229d8727-b26b-51ac-7b7e-e183607834c2@akeo.ie> Date: Mon, 31 Aug 2020 14:17:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200828220215.101919-6-jeremy.linton@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Thanks for this. On 2020.08.28 23:02, Jeremy Linton wrote: > Pete's review pointed out some whitespace issues in the > context of a previous patch. Since there are a number of > similar errors in the file lets fix them separately. > > Cc: Leif Lindholm > Cc: Pete Batard > Cc: Andrei Warkentin > Cc: Ard Biesheuvel > Cc: Samer El-Haj-Mahmoud > Signed-off-by: Jeremy Linton > --- > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 +++++++++++----------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > index d58cbbdfe7..2712194d2b 100644 > --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c > @@ -209,9 +209,9 @@ SetupVariables ( > } > > > > Size = sizeof (UINT32); > > - Status = gRT->GetVariable(L"CustomCpuClock", > > - &gConfigDxeFormSetGuid, > > - NULL, &Size, &Var32); > > + Status = gRT->GetVariable (L"CustomCpuClock", > > + &gConfigDxeFormSetGuid, > > + NULL, &Size, &Var32); > > if (EFI_ERROR (Status)) { > > Status = PcdSet32S (PcdCustomCpuClock, PcdGet32 (PcdCustomCpuClock)); > > ASSERT_EFI_ERROR (Status); > > @@ -256,9 +256,9 @@ SetupVariables ( > PcdSet32 (PcdFanOnGpio, PcdGet32 (PcdFanOnGpio)); > > } > > > > - Size = sizeof(AssetTagVar); > > + Size = sizeof (AssetTagVar); > > > > - Status = gRT->GetVariable(L"AssetTag", > > + Status = gRT->GetVariable (L"AssetTag", > > &gConfigDxeFormSetGuid, > > NULL, &Size, AssetTagVar); > > > > @@ -267,7 +267,7 @@ SetupVariables ( > L"AssetTag", > > &gConfigDxeFormSetGuid, > > EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, > > - sizeof(AssetTagVar), > > + sizeof (AssetTagVar), > > AssetTagVar > > ); > > } > > @@ -433,9 +433,9 @@ ApplyVariables ( > * spaces. SystemMemorySizeBelow4GB tracks the maximum memory below 4GB > > * line, factoring in the limit imposed by the SoC register range. > > */ > > - SystemMemorySizeBelow4GB = MIN(SystemMemorySize, 4UL * SIZE_1GB); > > - SystemMemorySizeBelow4GB = MIN(SystemMemorySizeBelow4GB, BCM2836_SOC_REGISTERS); > > - SystemMemorySizeBelow4GB = MIN(SystemMemorySizeBelow4GB, BCM2711_SOC_REGISTERS); > > + SystemMemorySizeBelow4GB = MIN (SystemMemorySize, 4UL * SIZE_1GB); > > + SystemMemorySizeBelow4GB = MIN (SystemMemorySizeBelow4GB, BCM2836_SOC_REGISTERS); > > + SystemMemorySizeBelow4GB = MIN (SystemMemorySizeBelow4GB, BCM2711_SOC_REGISTERS); > > > > ASSERT (SystemMemorySizeBelow4GB > 3UL * SIZE_1GB); > > > > @@ -528,14 +528,14 @@ ApplyVariables ( > /* > > * SD card pins go to Arasan. > > */ > > - MmioWrite32((GPIO_BASE_ADDRESS + 0xD0), > > - MmioRead32(GPIO_BASE_ADDRESS + 0xD0) | 0x2); > > + MmioWrite32 ((GPIO_BASE_ADDRESS + 0xD0), > > + MmioRead32 (GPIO_BASE_ADDRESS + 0xD0) | 0x2); > > } else { > > /* > > * SD card pins back to eMMC2. > > */ > > - MmioWrite32((GPIO_BASE_ADDRESS + 0xD0), > > - MmioRead32(GPIO_BASE_ADDRESS + 0xD0) & ~0x2); > > + MmioWrite32 ((GPIO_BASE_ADDRESS + 0xD0), > > + MmioRead32 (GPIO_BASE_ADDRESS + 0xD0) & ~0x2); > > /* > > * WiFi back to Arasan. > > */ > Reviewed-by: Pete Batard