* [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue
@ 2017-04-18 4:56 Guo, Mang
2017-04-18 8:25 ` Wei, David
0 siblings, 1 reply; 2+ messages in thread
From: Guo, Mang @ 2017-04-18 4:56 UTC (permalink / raw)
To: edk2-devel@lists.01.org; +Cc: Wei, David, Lu, ShifeiX A
Debug BIOS will assert if change setup and save.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang <mang.guo@intel.com>
---
.../PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c
index d504995..768893e 100644
--- a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c
+++ b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c
@@ -1808,7 +1808,6 @@ CheckSystemConfigSave (
SEC_INFOMATION SeCInfo;
UINT8 SecureBootCfg;
UINTN DataSize;
- BOOLEAN SecureBootNotFound;
Status = gBS->LocateProtocol (
&gEfiSeCOperationProtocolGuid,
@@ -1831,7 +1830,6 @@ CheckSystemConfigSave (
// Secure Boot configuration changes
//
DataSize = sizeof (SecureBootCfg);
- SecureBootNotFound = FALSE;
Status = gRT->GetVariable (
EFI_SECURE_BOOT_ENABLE_NAME,
&gEfiSecureBootEnableDisableGuid,
@@ -1841,18 +1839,7 @@ CheckSystemConfigSave (
);
if (EFI_ERROR (Status)) {
- SecureBootNotFound = TRUE;
- }
-
- if (SecureBootNotFound) {
- Status = gRT->GetVariable (
- EFI_SECURE_BOOT_ENABLE_NAME,
- &gEfiSecureBootEnableDisableGuid,
- NULL,
- &DataSize,
- &SecureBootCfg
- );
- ASSERT_EFI_ERROR (Status);
+ SecureBootCfg = 0;
}
if ((SecureBootCfg) != SystemConfigPtr->SecureBoot) {
--
2.10.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue
2017-04-18 4:56 [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue Guo, Mang
@ 2017-04-18 8:25 ` Wei, David
0 siblings, 0 replies; 2+ messages in thread
From: Wei, David @ 2017-04-18 8:25 UTC (permalink / raw)
To: Guo, Mang, edk2-devel@lists.01.org; +Cc: Lu, ShifeiX A
Reviewed-by: zwei4 <david.wei@intel.com>
Thanks,
David Wei
-----Original Message-----
From: Guo, Mang
Sent: Tuesday, April 18, 2017 12:57 PM
To: edk2-devel@lists.01.org
Cc: Wei, David <david.wei@intel.com>; Lu, ShifeiX A <shifeix.a.lu@intel.com>
Subject: [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue
Debug BIOS will assert if change setup and save.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang <mang.guo@intel.com>
---
.../PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c
index d504995..768893e 100644
--- a/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c
+++ b/Platform/BroxtonPlatformPkg/Common/PlatformSettings/PlatformSetupDxe/SetupInfoRecords.c
@@ -1808,7 +1808,6 @@ CheckSystemConfigSave (
SEC_INFOMATION SeCInfo;
UINT8 SecureBootCfg;
UINTN DataSize;
- BOOLEAN SecureBootNotFound;
Status = gBS->LocateProtocol (
&gEfiSeCOperationProtocolGuid,
@@ -1831,7 +1830,6 @@ CheckSystemConfigSave (
// Secure Boot configuration changes
//
DataSize = sizeof (SecureBootCfg);
- SecureBootNotFound = FALSE;
Status = gRT->GetVariable (
EFI_SECURE_BOOT_ENABLE_NAME,
&gEfiSecureBootEnableDisableGuid,
@@ -1841,18 +1839,7 @@ CheckSystemConfigSave (
);
if (EFI_ERROR (Status)) {
- SecureBootNotFound = TRUE;
- }
-
- if (SecureBootNotFound) {
- Status = gRT->GetVariable (
- EFI_SECURE_BOOT_ENABLE_NAME,
- &gEfiSecureBootEnableDisableGuid,
- NULL,
- &DataSize,
- &SecureBootCfg
- );
- ASSERT_EFI_ERROR (Status);
+ SecureBootCfg = 0;
}
if ((SecureBootCfg) != SystemConfigPtr->SecureBoot) {
--
2.10.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-18 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-18 4:56 [Patch][edk2-platforms/devel-MinnowBoard3] Fix setup assert issue Guo, Mang
2017-04-18 8:25 ` Wei, David
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox