From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=mang.guo@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F1DCA2096965F for ; Wed, 30 May 2018 23:49:29 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2018 23:49:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,463,1520924400"; d="scan'208";a="228750538" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 30 May 2018 23:49:28 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 30 May 2018 23:49:11 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 30 May 2018 23:49:10 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0319.002; Thu, 31 May 2018 14:48:25 +0800 From: "Guo, Mang" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Wei, David" Thread-Topic: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue Thread-Index: AdP39mFtxNkrXpdLSEiioTvE1l7k0wAMiDqAACCP+6A= Date: Thu, 31 May 2018 06:48:25 +0000 Message-ID: <22D2C85ED001C54AA20BFE3B0E4751D15268D7AA@SHSMSX103.ccr.corp.intel.com> References: <22D2C85ED001C54AA20BFE3B0E4751D15268D470@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 May 2018 06:49:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 ver= sion. Because this version OS needs larger SMM stack size to set variable. SMM stack size was changed from 0x2000 to 0x4000 to fix this issue. Updated the patch to provide a complete description of the change in the co= mmit message.=20 Thanks, Mang -----Original Message----- From: Kinney, Michael D=20 Sent: Wednesday, May 30, 2018 11:13 PM To: Guo, Mang; edk2-devel@lists.01.org; Kinney, Michael D Cc: Wei, David Subject: RE: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM s= tack size issue Guo, Can you please provide the old size and the new size in the commit message? Also, what changed that required a larger stack? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Guo, Mang > Sent: Wednesday, May 30, 2018 2:13 AM > To: edk2-devel@lists.01.org > Cc: Wei, David > Subject: [edk2] [Patch][edk2-platforms/devel- > MinnowBoardMax-UDK2017] Fix SMM stack size issue >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 >=20 > Signed-off-by: Guo Mang > --- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 6ebbb66..7f44f0a 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -1437,7 +1437,12 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/ > IA32/fTPMInitPeim.inf > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > - UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { > + > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000 > + } > + > + > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf >=20 > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf > -- > 2.10.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel