public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] MinnowBoard3 Module UART
@ 2018-08-22  2:57 Guo, Mang
  0 siblings, 0 replies; only message in thread
From: Guo, Mang @ 2018-08-22  2:57 UTC (permalink / raw)
  To: edk2-devel@lists.01.org; +Cc: Wei, David

1. Change MinnowBoard3 Module UART number from 0 to 2.
2. Add zero checking before SetVariable to avoid seting variable each time boot.

Cc: David Wei <david.wei@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Guo Mang <mang.guo@intel.com>
---
 .../Board/UP2/BoardInitDxe/BoardInitDxe.c            | 20 +++++++++++---------
 .../PlatformDsc/PcdsFixedAtBuild.dsc                 |  2 +-
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/Platform/BroxtonPlatformPkg/Board/UP2/BoardInitDxe/BoardInitDxe.c b/Platform/BroxtonPlatformPkg/Board/UP2/BoardInitDxe/BoardInitDxe.c
index 662d8f1..e0e2d93 100644
--- a/Platform/BroxtonPlatformPkg/Board/UP2/BoardInitDxe/BoardInitDxe.c
+++ b/Platform/BroxtonPlatformPkg/Board/UP2/BoardInitDxe/BoardInitDxe.c
@@ -63,15 +63,17 @@ UpdateSetupVariable (
   ASSERT_EFI_ERROR (Status);
 
   if (Status == EFI_SUCCESS) {
-    mSystemConfiguration.PcieRootPortEn[3]= (UINT8) 0;
-    Status = gRT->SetVariable (
-                    L"Setup",
-                    &gEfiSetupVariableGuid,
-                    VariableAttributes,
-                    VarSize,
-                    &mSystemConfiguration
-                    );
-    ASSERT_EFI_ERROR (Status);
+    if (mSystemConfiguration.PcieRootPortEn[3] != 0) {
+      mSystemConfiguration.PcieRootPortEn[3]= (UINT8) 0;
+      Status = gRT->SetVariable (
+                      L"Setup",
+                      &gEfiSetupVariableGuid,
+                      VariableAttributes,
+                      VarSize,
+                      &mSystemConfiguration
+                      );
+      ASSERT_EFI_ERROR (Status);
+    }
   }
   
   return Status;
diff --git a/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc b/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc
index db9b2e6..db7cba5 100644
--- a/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc
+++ b/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc
@@ -86,7 +86,7 @@
   
   gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x3000
   
-  !if $(UP2_BOARD) == TRUE || $(MINNOW3_MODULE_BOARD) == TRUE
+  !if $(UP2_BOARD) == TRUE
     gPlatformModuleTokenSpaceGuid.PcdSerialIoUartNumber|0
   !else 
     gPlatformModuleTokenSpaceGuid.PcdSerialIoUartNumber|2
-- 
2.10.1.windows.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-08-22  2:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-22  2:57 [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] MinnowBoard3 Module UART Guo, Mang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox