[edk2-devel] Regarding StandaloneMmPkg/Include/Guid/MpInformation.h

[edk2-devel] Regarding StandaloneMmPkg/Include/Guid/MpInformation.h

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

All,

StandaloneMmPkg/Include/Guid/MpInformation.h contains the MP_INFORMATION_HOB_DATA HOB definition.
This HOB is used for transfering MP information collected in non-SMM phase to standalone MM environment.

#pragma pack(1)
typedef struct {
  UINT64                       NumberOfProcessors;
  UINT64                       NumberOfEnabledProcessors;
  EFI_PROCESSOR_INFORMATION    ProcessorInfoBuffer[];
} MP_INFORMATION_HOB_DATA;
#pragma pack()

extern EFI_GUID  gMpInformationHobGuid;


Is there any reason that the MP_INFORMATION_HOB_DATA HOB definition not documented in PI spec?
If no reason, I do feel that PI spec needs to carry the HOB definition.
Thoughts?

Thanks,
Ray


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108307): https://edk2.groups.io/g/devel/message/108307
Mute This Topic: https://groups.io/mt/101187873/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7966 bytes --]

Re: [edk2-devel] Regarding StandaloneMmPkg/Include/Guid/MpInformation.h

[Oliver Smith-Denny]

On 9/5/2023 11:39 PM, Ni, Ray wrote:
> All,
> 
> StandaloneMmPkg/Include/Guid/MpInformation.h contains the 
> MP_INFORMATION_HOB_DATA HOB definition.
> This HOB is used for transfering MP information collected in non-SMM 
> phase to standalone MM environment.
> 
> #pragmapack(1)
> typedefstruct{
> UINT64NumberOfProcessors;
> UINT64NumberOfEnabledProcessors;
> EFI_PROCESSOR_INFORMATIONProcessorInfoBuffer[];
> }MP_INFORMATION_HOB_DATA;
> #pragmapack()
> 
> externEFI_GUIDgMpInformationHobGuid;
> 
> 
> Is there any reason that the MP_INFORMATION_HOB_DATA HOB definition not 
> documented in PI spec?
> If no reason, I do feel that PI spec needs to carry the HOB definition.
> Thoughts?
> 

That seems reasonable to me. I was reviewing the PI spec recently to get
Standalone MM information, it is pretty sparse in general, in particular
where it relates to HOBs. I think more clarification for Standalone MM
in relation to HOBs would be helpful.

I see you are already on the other thread
(StandaloneMMPkg: Fix HOB Space and heap space conflicted issue), where
we are discussing just such a confusion in the PI spec.

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108332): https://edk2.groups.io/g/devel/message/108332
Mute This Topic: https://groups.io/mt/101187873/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-