From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4F1B621102DAC for ; Thu, 23 Aug 2018 04:29:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 699A377886; Thu, 23 Aug 2018 11:29:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-237.rdu2.redhat.com [10.10.120.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id B46ED10CD7C8; Thu, 23 Aug 2018 11:29:29 +0000 (UTC) To: Haojian Zhuang , edk2-devel@lists.01.org References: <1535003502-15734-1-git-send-email-haojian.zhuang@linaro.org> From: Laszlo Ersek Message-ID: <22c2f2a7-fd26-9d06-829b-c0c4bad8c23f@redhat.com> Date: Thu, 23 Aug 2018 13:29:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1535003502-15734-1-git-send-email-haojian.zhuang@linaro.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 23 Aug 2018 11:29:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 23 Aug 2018 11:29:30 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 11:29:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/23/18 07:51, Haojian Zhuang wrote: > Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise, > the hotkey of boot option won't be registered correctly. > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > index f9c71d430c99..81d36f218700 100644 > --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > @@ -479,7 +479,7 @@ GetPlatformOptions ( > NULL, > BootOptionNumber, > 0, > - BootKeys[Index], > + &BootKeys[Index], > NULL > ); > if (EFI_ERROR (Status)) { > I'm sorry I didn't notice this while reviewing the patch that would end up as commit 1b6e7633cad8 ("ArmPkg/PlatformBootManagerLib: load platform boot options", 2018-06-05). Also, ellipses are tricky; the compiler couldn't help. Please add the following to the commit message, just above the Contributed-under line: Fixes: 1b6e7633cad8135547f337eeef47f446f57a2505 With that: Reviewed-by: Laszlo Ersek Thanks, Laszlo