From: "Laszlo Ersek" <lersek@redhat.com>
To: abner.chang@hpe.com, Bob Feng <bob.c.feng@intel.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform
Date: Wed, 29 Apr 2020 12:15:00 +0200 [thread overview]
Message-ID: <22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com> (raw)
In-Reply-To: <20200423135233.7342-1-abner.chang@hpe.com>
Hi Abner, Bob,
On 04/23/20 15:52, Abner Chang wrote:
> BZ for entire RISC-V edk2 port,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2672
>
> These commits are verified by below PR,
> https://github.com/tianocore/edk2/pull/512
>
> In v4, GCC5_ASM_FLAGS is replaced by GCC5_RISCV64_ASM_FLAGS in
> tools_def.template in 3/3 patch.
>
> Abner Chang (3):
> BaseTools: BaseTools changes for RISC-V platform.
> BaseTools: BaseTools changes for RISC-V platform.
> BaseTools: BaseTools changes for RISC-V platform.
Please don't write patch subjects like this. If I look at the git commit
history now (just the subject lines), I see:
$ git log --oneline --reverse cdc3fa54184a..f60d5ca97f25
ad1db975c0ca BaseTools: BaseTools changes for RISC-V platform.
178938b2b9b4 BaseTools: BaseTools changes for RISC-V platform.
f60d5ca97f25 BaseTools: BaseTools changes for RISC-V platform.
These subjects are nearly useless, especially three of them grouped
together.
The following would have been better (trivially composed from the bodies
of the commit messages):
BaseTools: C code changes for building EDK2 RISC-V platform
BaseTools: Tools def. template updates for building EDK2 RISC-V platform
BaseTools: Python code changes for building EDK2 RISC-V platform
Bob: please remember that it's reviewer / maintainer responsibility as
well to maintain a high level of commit message quality. The git commit
history is relevant to the entire community, not just BaseTools owners.
Thanks
Laszlo
>
> BaseTools/Source/C/Common/PeCoffLib.h | 9 +
> BaseTools/Source/C/GenFw/elf_common.h | 62 ++++
> .../C/Include/IndustryStandard/PeImage.h | 6 +
> BaseTools/Source/C/Common/BasePeCoff.c | 15 +-
> BaseTools/Source/C/Common/PeCoffLoaderEx.c | 86 ++++++
> BaseTools/Source/C/GenFv/GenFvInternalLib.c | 128 +++++++-
> BaseTools/Source/C/GenFw/Elf32Convert.c | 5 +-
> BaseTools/Source/C/GenFw/Elf64Convert.c | 282 +++++++++++++++++-
> BaseTools/Conf/tools_def.template | 53 +++-
> BaseTools/Source/Python/Common/DataType.py | 5 +-
> BaseTools/Source/Python/build/buildoptions.py | 6 +-
> 11 files changed, 638 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2020-04-29 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 13:52 [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform Abner Chang
2020-04-23 13:52 ` [PATCH v4 1/3] " Abner Chang
2020-04-23 13:52 ` [PATCH v4 2/3] " Abner Chang
2020-04-23 13:52 ` [PATCH v4 3/3] " Abner Chang
2020-04-24 9:23 ` Bob Feng
[not found] ` <1608B727235F9D81.20497@groups.io>
2020-04-28 10:38 ` [edk2-devel] " Bob Feng
2020-04-28 14:54 ` Abner Chang
2020-04-29 10:15 ` Laszlo Ersek [this message]
2020-04-29 10:48 ` [edk2-devel] [PATCH v4 0/3] " Bob Feng
2020-04-29 13:53 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox