From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.1008.1588155308960617901 for ; Wed, 29 Apr 2020 03:15:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HKdUilww; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588155308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ydkbWyUt9pCGCFkgKhMMwS0sfQ36iD0R+ci7++rAgDU=; b=HKdUilwwbXp3cVUGQOKPbo2xbJhWd0CRXXXqH1qcazSX7zf/a9PJA7xdVIrxLSN4Euvq6A +vXkz8NyFkPOXkQj9ENKLQ+vPqP6XBiSqSBwtN9Y0TyJNI6QCMkPEaEVB2I8Q+kQvmwOtn 7SSA999OBm5d5XfpcOP8pbnnbjza25M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-0atxjtHGOdWhe2MkyqUgqA-1; Wed, 29 Apr 2020 06:15:02 -0400 X-MC-Unique: 0atxjtHGOdWhe2MkyqUgqA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD4D3107BEF5; Wed, 29 Apr 2020 10:15:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-1.ams2.redhat.com [10.36.114.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id F222619C4F; Wed, 29 Apr 2020 10:15:00 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform To: abner.chang@hpe.com, Bob Feng References: <20200423135233.7342-1-abner.chang@hpe.com> Cc: devel@edk2.groups.io From: "Laszlo Ersek" Message-ID: <22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com> Date: Wed, 29 Apr 2020 12:15:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200423135233.7342-1-abner.chang@hpe.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hi Abner, Bob, On 04/23/20 15:52, Abner Chang wrote: > BZ for entire RISC-V edk2 port, > https://bugzilla.tianocore.org/show_bug.cgi?id=2672 > > These commits are verified by below PR, > https://github.com/tianocore/edk2/pull/512 > > In v4, GCC5_ASM_FLAGS is replaced by GCC5_RISCV64_ASM_FLAGS in > tools_def.template in 3/3 patch. > > Abner Chang (3): > BaseTools: BaseTools changes for RISC-V platform. > BaseTools: BaseTools changes for RISC-V platform. > BaseTools: BaseTools changes for RISC-V platform. Please don't write patch subjects like this. If I look at the git commit history now (just the subject lines), I see: $ git log --oneline --reverse cdc3fa54184a..f60d5ca97f25 ad1db975c0ca BaseTools: BaseTools changes for RISC-V platform. 178938b2b9b4 BaseTools: BaseTools changes for RISC-V platform. f60d5ca97f25 BaseTools: BaseTools changes for RISC-V platform. These subjects are nearly useless, especially three of them grouped together. The following would have been better (trivially composed from the bodies of the commit messages): BaseTools: C code changes for building EDK2 RISC-V platform BaseTools: Tools def. template updates for building EDK2 RISC-V platform BaseTools: Python code changes for building EDK2 RISC-V platform Bob: please remember that it's reviewer / maintainer responsibility as well to maintain a high level of commit message quality. The git commit history is relevant to the entire community, not just BaseTools owners. Thanks Laszlo > > BaseTools/Source/C/Common/PeCoffLib.h | 9 + > BaseTools/Source/C/GenFw/elf_common.h | 62 ++++ > .../C/Include/IndustryStandard/PeImage.h | 6 + > BaseTools/Source/C/Common/BasePeCoff.c | 15 +- > BaseTools/Source/C/Common/PeCoffLoaderEx.c | 86 ++++++ > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 128 +++++++- > BaseTools/Source/C/GenFw/Elf32Convert.c | 5 +- > BaseTools/Source/C/GenFw/Elf64Convert.c | 282 +++++++++++++++++- > BaseTools/Conf/tools_def.template | 53 +++- > BaseTools/Source/Python/Common/DataType.py | 5 +- > BaseTools/Source/Python/build/buildoptions.py | 6 +- > 11 files changed, 638 insertions(+), 19 deletions(-) >